Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AssetMapper to UrlNormalizer #178

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Add AssetMapper to UrlNormalizer #178

merged 1 commit into from
Apr 22, 2024

Conversation

Spomky
Copy link
Member

@Spomky Spomky commented Apr 22, 2024

Integrated the AssetMapperInterface into the UrlNormalizer class. Updated the process to check if the path is an asset and return the public path accordingly. Also, added error handling in the case of URL generation failure.

Target branch: 1.2.x
Resolves issue #174

  • It is a Bug fix
  • It is a New feature
  • Breaks BC
  • Includes Deprecations

Integrated the AssetMapperInterface into the UrlNormalizer class. Updated the process to check if the path is an asset and return the public path accordingly. Also, added error handling in the case of URL generation failure.
@Spomky Spomky added the enhancement New feature or request label Apr 22, 2024
@Spomky Spomky added this to the 1.2.0 milestone Apr 22, 2024
@Spomky Spomky self-assigned this Apr 22, 2024
@Spomky Spomky merged commit e39641a into 1.2.x Apr 22, 2024
7 checks passed
@Spomky Spomky deleted the features/path-to-asset branch April 22, 2024 18:19
@Spomky Spomky linked an issue Apr 22, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preload Assets
1 participant