Implement localization support in Progressive Web App bundle #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spomky
force-pushed
the
features/better-translations
branch
4 times, most recently
from
f3df949
to
e8fbfef
Compare
|
Ping @tacman. This PR will allow to generate multiple translated manifest files.
pwa:
manifest:
enabled: true
locales:
- 'en'
- 'de'
public_url: 'site.{locale}.webmanifest'
<?xml version="1.0" encoding="utf-8"?>
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" version="1.2">
<file source-language="en" target-language="en" datatype="plaintext" original="file.ext">
<header>
<tool tool-id="symfony" tool-name="Symfony"/>
</header>
<body>
<trans-unit id="VKDowX61" resname="app.name">
<source>app.name</source>
<target>My PWA</target>
</trans-unit>
</body>
</file>
</xliff>
|
Updated various modules to support localization, primarily adjusting how manifest files are generated and served. Added new "locales" configuration parameter, made necessary adjustments in manifest and service worker compilers. Additionally, refactored the twig runtime to properly handle localized manifest URLs.
Spomky
force-pushed
the
features/better-translations
branch
from
e8fbfef
to
7d0cf22
Compare
Closed
|
Shouldn't the locales default to the framework enabled_locales key? That way we don't have to manually keep them in sync. https://symfony.com/doc/current/reference/configuration/framework.html#enabled-locales |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated various modules to support localization, primarily adjusting how manifest files are generated and served. Added new "locales" configuration parameter, made necessary adjustments in manifest and service worker compilers. Additionally, refactored the twig runtime to properly handle localized manifest URLs.
Target branch:
Resolves issue #