Refactor prefetch method to use async/await #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the prefetch method in prefetch-on-demand_controller to use async/await for better error handling. The response from the workbox.messageSW method call is now awaited, and an event is dispatched based on the result, informing whether prefetching was successful or not.
|
Please be aware that Workbox will consistently return 'true', regardless of whether any of the URLs failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the prefetch method in prefetch-on-demand_controller to use async/await for better error handling. The response from the workbox.messageSW method call is now awaited, and an event is dispatched based on the result, informing whether prefetching was successful or not.
Target branch: 1.2.x
Resolves issue #192