Update favicon processing to include hashing #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modifications to the FaviconsCompiler service now includes hashing in the favicon processing. This includes changes to the structure of the URL and the generation of a unique hash based on the image content and configuration. This update also has some error handling improvements, including better handling of file reading failures. This provides more robust processing and clearer URLs which include the hash of the specific favicon configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modifications to the FaviconsCompiler service now includes hashing in the favicon processing. This includes changes to the structure of the URL and the generation of a unique hash based on the image content and configuration. This update also has some error handling improvements, including better handling of file reading failures. This provides more robust processing and clearer URLs which include the hash of the specific favicon configuration.
Target branch: 1.2.x
Resolves issue #204