Update method return types and yield statements #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The methods' return types have been updated from iterable<Data> to iterable<string, Data> in several files, namely FaviconsCompiler.php, ManifestCompiler.php, FileCompilerInterface.php, and ServiceWorkerCompiler.php. Moreover, yield statements have been modified to yield a pair of string (URL) and Data instead of just Data to enhance data identification and access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods' return types have been updated from iterable to iterable<string, Data> in several files, namely FaviconsCompiler.php, ManifestCompiler.php, FileCompilerInterface.php, and ServiceWorkerCompiler.php. Moreover, yield statements have been modified to yield a pair of string (URL) and Data instead of just Data to enhance data identification and access.
Target branch: 1.2.x
Resolves issue #216