New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call to disable alphabetical order. #31
Comments
It won't just be a problem for dev's admins get quite possessive over the layout and order of their plugin configs. |
@ryantheleach Yeah. When I ran a server I liked it when things were sorted by category. |
I reported this few months ago: Can this be fixed by creating a fork of the typesafe hocon library? |
possibly? but I don't really have the time to maintain that. |
Just noticed this issue myself. Hopefully it can be resolved soon. I've tried setting the configuration options, but that doesn't seem to do anything when using Hocon. |
This is an issue with the hocon library itself, and new versions of the hocon library require jdk8 so this is not something simple to fix at all. |
Is the issue already resolved in newer versions of the hocon library or is it just a matter of being to test it to find out? |
It doesn't look like the map implementation used by the Hocon library has changed. However, newer library versions allow us to pass whatever map implementation we want. Unfortunately, we can't use the newer library version until we don't have users who require jdk6 (Sponge). |
|
gonna leave this as a wontfix. That will change once configurate is on jdk8 though. |
Since Sponge is now JDK8, is there a chance to reopen and fix the problem? |
Possibly, I'll take a look at it. |
Should this perhaps be kept open until it has been decided on whether or not the JDK8 migration can potentially solve the issue? |
This partially fixes #31 when writing new data. However, reading a configuration file in still does not preserve node order. This would require changes in the HOCON library -- take a look at https://github.com/typesafehub/config/blob/v1.3.0/config/src/main/java/com/typesafe/config/impl/ConfigParser.java#L215 for the specific line that would need to be changed.
Any chance that using the |
Are there any HOCON parsers that keep values order? |
Is this ever going to be came back to or not? |
Will this be fixed at some point? This is a pain in the ass |
@zml2008 Hasn't had a ton of time lately, @codeHusky @jamezrin Are you volunteering to potentially add support for the new ConfigDocument API? That seems the only sane method considering Typesafe's current stance. |
I know nothing about this codebase. |
Any updates on this issue. Not preserving order is very frustrating |
this has pretty much always been a hocon issue, do they support maintaining order yet?
…________________________________
From: Crypnotic <notifications@github.com>
Sent: Wednesday, January 23, 2019 2:11:13 PM
To: SpongePowered/configurate
Cc: Zach Levis; Mention
Subject: Re: [SpongePowered/configurate] Call to disable alphabetical order. (#31)
Any updates on this issue. Not preserving order is very frustrating
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#31 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAmZZHsfN-M4AwaVVmk_jNoW6X8kKr0jks5vGN4BgaJpZM4EQzK2>.
|
I'm not too familiar with how configurate interacts with the hocon library, but according to the latest comment on: lightbend/config#365 Edit: Checked out the loader very briefly and it seems like no methods are used that the comment says to be wary of |
To be fair, it's a hacked fork. could break at any stage, if you attempt to keep it updated. Which may be fine for SpongeForge/SpongeCommon but I think most people would rather not have those hacks in Configurate. I suspect there's an alternate way, by getting Configurate to use the dedicated document editing API's for modifying values, but that could be quite difficult to implement potentially. |
Since at the moment it looks like we've done everything we can do on the Configurate side, any further change would have to happen on the underlying library. It also looks like our use case is not a priority for the Hocon developers, so the issue is unlikely to be fixed in the near future. I'll close this issue since it's unlikely we'll make progress on it as things currently stand, but I do hope that changes in the future. |
If I want my config to look like this:
version="0.3"
node1 = "banana"
aForApple="yes"
I can't because nodes are locked in alphabetical order. If I could disable that, I could get that outcome.
The text was updated successfully, but these errors were encountered: