Add Custom Data recipe

[ZephireNZ]

• Simple Data
• Compound Data
• DataBuilder
• DataContentUpdater
• DataTranslator
• Keys

Built as a complete example for SpongeDocs#532

Should cover everything that #16 covers and more.

[gabizou]

Should note that Home as a DataSerializable should be registered before any data manipulator that relies on it can be registered. The reasoning is that in SpongePowered/SpongeAPI#1198, the system will need to know of all of the serializable objects and translatable objects before it can generate the appropriate serialization strategies for custom data.

[ryantheleach]

Is there any error or exception if they arn't? having the check would help developers catch this mistake in the future.

[ZephireNZ]

I'd imagine that there'll be logic along the lines of:

for value in values:
    if value.obj is dataserialiable:
        toContainer
    if value.obj is primitive, map, list
        set directly
    if value.obj has registered translator:
        get translator, translate
    throw RuntimeException of some form

[gabizou]

The issue is more about generating he deserialization methods with class generation.

[ZephireNZ]

I'll be making another PR for data 2.0 for docs and cookbook so that we
have records for both, so I'll make sure to include that. But right now it
doesn't matter, correct?

On Tue., 8 Nov. 2016, 6:30 am Gabriel Harris-Rouquette, <
notifications@github.com> wrote:

@gabizou commented on this pull request.

In
Plugin/MyHomes/src/main/java/org/spongepowered/cookbook/myhomes/MyHomes.java
#17 (review)
:

+import org.spongepowered.api.text.Text;
+import org.spongepowered.api.text.chat.ChatTypes;
+import org.spongepowered.api.text.format.TextStyles;
+
+@plugin(id = "myhomes")
+public class MyHomes {
+

• @Listener
• public void onGameInitialization(GameInitializationEvent event) {

•    DataManager dm = Sponge.getDataManager();
  

•    // FriendsData
  

•    dm.register(FriendsDataImpl.class, ImmutableFriendsDataImpl.class, new FriendsDataBuilder());
  

•    // Home
  

•    dm.registerBuilder(Home.class, new HomeBuilder());
  

Should note that Home as a DataSerializable should be registered before
any data manipulator that relies on it can be registered. The reasoning is
that in SpongePowered/SpongeAPI#1198
SpongePowered/SpongeAPI#1198, the system will
need to know of all of the serializable objects and translatable objects
before it can generate the appropriate serialization strategies for custom
data.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#17 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABkX0NCagVGGyxxAy3hmDuZ-IeX22d3Sks5q72ApgaJpZM4KrG0p
.

[ZephireNZ]

Hey, could this be merged? At the moment there's a dead link in the Docs as I was expecting for this to be pulled.

Let me know if there's something that needs to be changed.

[Tzky]

Bump. See Zephires comment above mine. The link on the docs is (still) broken.