Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixins with DCEVM hang on hotswap. #592

Open
codecnotsupported opened this issue Jul 24, 2022 · 6 comments
Open

Mixins with DCEVM hang on hotswap. #592

codecnotsupported opened this issue Jul 24, 2022 · 6 comments

Comments

@codecnotsupported
Copy link

codecnotsupported commented Jul 24, 2022

The fabric wiki Mentions that
"When run on JetBrains Runtime's Java 17 fork (with DCEVM), Mixin hotswapping and DCEVM work properly."

There are two ways to use DCEVM with java 17.

  • A: (Able to launch with quilt): Follow the tutorial below and use the hotswap-agent.jar with the latest JetBrainsRuntime

  • B: (Able to launch fabric & quilt): Use a outdated version of JetBrains Runtime's Java (jbrsdk_dcevm-17_0_1) which I presume bundles the hotswap-agent.

Setup:
java VM arguments:

-XX:HotswapAgent=fatjar ( Only applicable for option A )
-XX:+AllowEnhancedClassRedefinition  
-javaagent:"path_to/sponge-mixin-0.11.2+mixin.0.8.5.jar"

When hotswapping it prints:
[JDWP Transport Listener: dt_socket/INFO]: Redefining mixin com/example/example_mod/mixin/ArrowEntityMixin
Then the loading bar in InteliJ Idea just hangs.

Other observations:

Hotswap agent has suppport for plugins
But I don't think Mixin takes advantage of that?

@codecnotsupported
Copy link
Author

It seems merely using JetBrainsRuntime JDK with
-XX:+AllowEnhancedClassRedefinition is enough to make the hotswap task hang, meaning HotswapAgent is probably not the cause.

@Barteks2x
Copy link

This definitely used to work on java 8 dcevm on 1.12.2.
On newer versions on modlauncher the only time o tried, it didn't yet work (classloading issue on hotswap attempt).

@MDevVal
Copy link

MDevVal commented Aug 21, 2023

With or without hotspot agent loaded on jbr_17
-XX:+AllowEnhancedClassRedefinition -javaagent:"sponge-mixin-0.12.5+mixin.0.8.5.jar"
hangs for me

@norpie
Copy link

norpie commented Oct 5, 2023

Has anyone found a fix for this?

@Floweynt
Copy link

Has anyone found a fix for this?

It seems like downgrading JBR works: https://github.com/JetBrains/JetBrainsRuntime/releases/tag/jbr17_0_1b164.8

@ButterSus
Copy link

Downgrading JBR doesn't help in my case. Seems like hotswapping mixins is broken for Java 17+. Hope this will get fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants