Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some changes in the base layout #731

Merged
merged 4 commits into from
Jan 20, 2019
Merged

Some changes in the base layout #731

merged 4 commits into from
Jan 20, 2019

Conversation

felixoi
Copy link
Member

@felixoi felixoi commented Jan 15, 2019 •
edited
Loading

Stuff fixed here:

  • Javascript is always added at the end of body
  • The base container was moved to the base layout and always has the top margin when the nav is shown
  • Alerts were moved to base layout, this allows to redirect with error in every template

Includes a fix for #732.

@felixoi felixoi mentioned this pull request Jan 15, 2019
Open
4 tasks
@felixoi felixoi changed the title [WIP] Some changes in the base layout Some changes in the base layout Jan 16, 2019
@felixoi felixoi requested a review from Katrix January 16, 2019 18:22
@felixoi felixoi merged commit 2c12be2 into master Jan 20, 2019
@progwml6 progwml6 deleted the refactor/layout branch January 22, 2019 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Katrix Katrix Katrix approved these changes

Assignees

@felixoi felixoi

Labels
status: ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@felixoi @Katrix @limbo-app