Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix world loading when allow-nether is false #121

Closed
wants to merge 1 commit into from
Closed

Fix world loading when allow-nether is false #121

wants to merge 1 commit into from

Conversation

JBYoshi
Copy link
Member

@JBYoshi JBYoshi commented Aug 5, 2015

This pull request prevents worlds, other than the overworld, from loading if allow-nether in server.properties is set to false. See #118.

@me4502
Copy link
Contributor

me4502 commented Aug 9, 2015

I'm not sure if I agree with this.

That option disables the vanilla nether, which is still possible with multi world support.

@JBYoshi
Copy link
Member Author

JBYoshi commented Aug 9, 2015

@me4502 According to blood in #287:

We will be handling "allow-nether" as allowMultipleDimensions to be consistent with Forge.

And:

I pushed a new branch 'world-update' which has the functionality you need via our world configs. To disable a world or dimension, locate the config under ./config/Sponge and set 'world-enabled' to false.

@JBYoshi JBYoshi force-pushed the fix/allow-nether-false branch 4 times, most recently from e8b3f04 to 998ac38 Compare August 15, 2015 02:08
@Zidane
Copy link
Member

Zidane commented Sep 26, 2015

@JBYoshi

Not sure if I want to even honor that setting via Vanilla. @bloodmc do we want to keep this to our configs or allow this as a "vanilla-override"

@gabizou gabizou added status: needs testing does this run, does it solve the issue etc status: needs updating hey, origin changed, you need to update labels Oct 5, 2015
@JBYoshi JBYoshi force-pushed the fix/allow-nether-false branch 3 times, most recently from a60326d to dc43862 Compare October 23, 2015 21:41
@JBYoshi
Copy link
Member Author

JBYoshi commented Oct 30, 2015

@Zidane @bloodmc Status?

@bloodmc
Copy link
Contributor

bloodmc commented Dec 14, 2015

@JBYoshi Please update this branch with current master.

@JBYoshi
Copy link
Member Author

JBYoshi commented Dec 15, 2015

@bloodmc Done.

@gabizou gabizou removed the status: needs updating hey, origin changed, you need to update label Dec 15, 2015
@bloodmc bloodmc closed this in 0331c27 Dec 16, 2015
@JBYoshi JBYoshi deleted the fix/allow-nether-false branch December 16, 2015 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: needs testing does this run, does it solve the issue etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JBYoshi @me4502 @Zidane @bloodmc @gabizou