Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement all missing entities and remove overrides on default impl data values. [1.14] #2468

Merged
merged 1 commit into from Jan 10, 2020
Merged

Implement all missing entities and remove overrides on default impl data values. [1.14] #2468

merged 1 commit into from Jan 10, 2020

Conversation

i509VCB
Copy link
Contributor

@i509VCB i509VCB commented Jan 5, 2020

No description provided.

@i509VCB i509VCB force-pushed the api/entities/new_114_p1 branch 2 times, most recently from a19e559 to 0334629 Compare January 5, 2020 22:19
@i509VCB i509VCB changed the title Implement all missing entities [1.14] Implement all missing entities and remove overrides on default impl data values. [1.14] Jan 5, 2020
@i509VCB i509VCB force-pushed the api/entities/new_114_p1 branch 2 times, most recently from fe5af94 to dc6d8ee Compare January 8, 2020 04:25
gabizou
gabizou requested changes Jan 8, 2020
View reviewed changes
Copy link
Member

@gabizou gabizou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All legacy data manipulator methods should be deleted if they've been transcribed as value getters now. Don't add an outer if statement when the value is already returning an Optional and an ifPresent wraps around adding to the values set. If the value is present (by the provider system), it'll be present, no need to check implementation detail for it. Also, licenses ;)

src/main/java/org/spongepowered/common/mixin/accessor/entity/passive/FoxEntityAccessor.java Show resolved Hide resolved
src/main/java/org/spongepowered/common/mixin/api/mcp/entity/EntityMixin_API.java Outdated Show resolved Hide resolved
src/main/java/org/spongepowered/common/mixin/api/mcp/entity/MobEntityMixin_API.java Outdated Show resolved Hide resolved
...va/org/spongepowered/common/mixin/api/mcp/entity/boss/dragon/EnderDragonEntityMixin_API.java Outdated Show resolved Hide resolved
...ain/java/org/spongepowered/common/mixin/api/mcp/entity/item/EnderCrystalEntityMixin_API.java Outdated Show resolved Hide resolved
.../spongepowered/common/mixin/api/mcp/entity/projectile/DamagingProjectileEntityMixin_API.java Outdated Show resolved Hide resolved
...a/org/spongepowered/common/mixin/api/mcp/entity/projectile/FishingBobberEntityMixin_API.java Outdated Show resolved Hide resolved
...a/org/spongepowered/common/mixin/api/mcp/entity/projectile/ShulkerBulletEntityMixin_API.java Outdated Show resolved Hide resolved
...a/org/spongepowered/common/mixin/api/mcp/entity/projectile/ShulkerBulletEntityMixin_API.java Outdated Show resolved Hide resolved
...a/org/spongepowered/common/mixin/api/mcp/entity/projectile/ShulkerBulletEntityMixin_API.java Outdated Show resolved Hide resolved
gabizou
gabizou requested changes Jan 9, 2020
View reviewed changes
src/main/java/org/spongepowered/common/mixin/api/mcp/entity/EntityMixin_API.java Show resolved Hide resolved
...in/java/org/spongepowered/common/mixin/api/mcp/entity/item/ExperienceOrbEntityMixin_API.java Outdated Show resolved Hide resolved
.../spongepowered/common/mixin/api/mcp/entity/item/minecart/SpawnerMinecartEntityMixin_API.java Show resolved Hide resolved
src/main/java/org/spongepowered/common/mixin/api/mcp/entity/MobEntityMixin_API.java Outdated Show resolved Hide resolved
...main/java/org/spongepowered/common/mixin/api/mcp/entity/monster/EndermanEntityMixin_API.java Show resolved Hide resolved
...ava/org/spongepowered/common/mixin/api/mcp/entity/projectile/EvokerFangsEntityMixin_API.java Outdated Show resolved Hide resolved
@i509VCB i509VCB force-pushed the api/entities/new_114_p1 branch 2 times, most recently from ede81e2 to 7636003 Compare January 9, 2020 20:22
@i509VCB
Implement all missing entities from 1.14 and remove old implementatio…
59b2eba 
…ns of data values which override default methods.

The real big one, add api$getVanillaValues to all entities and implement about 90% of the adding to Sets
@Zidane Zidane merged commit c5f11aa into SpongePowered:api-8 Jan 10, 2020
@i509VCB i509VCB deleted the api/entities/new_114_p1 branch January 30, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zidane Zidane Zidane left review comments

@Cybermaxke Cybermaxke Cybermaxke left review comments

@gabizou gabizou gabizou requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@i509VCB @Zidane @gabizou @Cybermaxke