Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start moving some simpler things to new tracker package [API-8]. #2499

Merged
merged 1 commit into from Feb 11, 2020

Conversation

i509VCB
Copy link
Contributor

@i509VCB i509VCB commented Feb 7, 2020

Moves Bone meal handling and DragonFightManager tracker hooks to the tracker mixin package.

Also converted the large overwrite in the old DragonFightManagerMixin and replaced it with a redirect (gabizou you'll want to make sure I didn't royally screw up here lol) since the reference to process the dragonSpawnState only occurs once.

Copy link
Member

@gabizou gabizou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new redirects/injects should have improved method names, otherwise, good stuff!

Copy link
Member

@gabizou gabizou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll get to merge this in tonight.

@gabizou gabizou merged commit 71e97ec into SpongePowered:api-8 Feb 11, 2020
@i509VCB i509VCB deleted the api/trackerstuff branch January 30, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants