Begin cleanup of core plugin entity mixins #2503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabizou
reviewed
Feb 14, 2020
src/main/java/org/spongepowered/common/mixin/core/entity/EntityMixin.java
Outdated
Show resolved
Hide resolved
gabizou
reviewed
Feb 14, 2020
src/main/java/org/spongepowered/common/mixin/core/entity/EntityMixin.java
Outdated
Show resolved
Hide resolved
gabizou
requested changes
Feb 14, 2020
src/main/java/org/spongepowered/common/mixin/core/entity/EntityMixin.java
Outdated
Show resolved
Hide resolved
src/main/java/org/spongepowered/common/mixin/core/entity/EntityMixin.java
Outdated
Show resolved
Hide resolved
src/main/java/org/spongepowered/common/mixin/core/entity/EntityMixin.java
Outdated
Show resolved
Hide resolved
src/main/java/org/spongepowered/common/mixin/core/entity/EntityMixin.java
Show resolved
Hide resolved
src/main/java/org/spongepowered/common/mixin/core/entity/EntityMixin.java
Outdated
Show resolved
Hide resolved
...a/org/spongepowered/common/mixin/core/entity/monster/EndermanEntity_PlaceBlockGoalMixin.java
Outdated
Show resolved
Hide resolved
...rg/spongepowered/common/mixin/core/entity/monster/SilverfishEntity_HideInStoneGoalMixin.java
Outdated
Show resolved
Hide resolved
src/main/java/org/spongepowered/common/mixin/core/entity/projectile/ThrowableEntityMixin.java
Outdated
Show resolved
Hide resolved
src/main/java/org/spongepowered/common/mixin/core/entity/projectile/ThrowableEntityMixin.java
Outdated
Show resolved
Hide resolved
src/main/java/org/spongepowered/common/mixin/core/entity/projectile/ThrowableEntityMixin.java
Outdated
Show resolved
Hide resolved
i509VCB
force-pushed
the
api/core/fixupentities
branch
3 times, most recently
from
735f108
to
92a4e95
Compare
gabizou
requested changes
Feb 21, 2020
src/main/java/org/spongepowered/common/mixin/core/entity/EntityMixin.java
Outdated
Show resolved
Hide resolved
src/main/java/org/spongepowered/common/mixin/core/entity/EntityMixin.java
Show resolved
Hide resolved
...rg/spongepowered/common/mixin/core/entity/merchant/villager/AbstractVillagerEntityMixin.java
Outdated
Show resolved
Hide resolved
...rg/spongepowered/common/mixin/core/entity/merchant/villager/AbstractVillagerEntityMixin.java
Outdated
Show resolved
Hide resolved
...rg/spongepowered/common/mixin/core/entity/merchant/villager/AbstractVillagerEntityMixin.java
Outdated
Show resolved
Hide resolved
src/main/java/org/spongepowered/common/mixin/core/entity/player/PlayerEntityMixin.java
Outdated
Show resolved
Hide resolved
src/main/java/org/spongepowered/common/mixin/core/entity/player/PlayerEntityMixin.java
Outdated
Show resolved
Hide resolved
src/main/java/org/spongepowered/common/mixin/core/entity/player/PlayerEntityMixin.java
Outdated
Show resolved
Hide resolved
src/main/java/org/spongepowered/common/mixin/tracker/entity/LivingEntityMixin_Tracker.java
Outdated
Show resolved
Hide resolved
src/main/java/org/spongepowered/common/mixin/tracker/entity/LivingEntityMixin_Tracker.java
Outdated
Show resolved
Hide resolved
i509VCB
force-pushed
the
api/core/fixupentities
branch
2 times, most recently
from
1538ebb
to
70b1302
Compare
…ng constant, clean up and make most of core entity mixins compile
i509VCB
force-pushed
the
api/core/fixupentities
branch
from
70b1302
to
7e5938c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make references to GameRules refer to actual RuleKey rather than string constant, clean up and make most of core entity mixins compile
Cleans up quite a chunk of core entity mixins so more of it can compile.