Update Chest API for new merging logic. #2554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The customName was moved to LockableTileEntity in Vanilla.
i509VCB
reviewed
Apr 6, 2020
...xins/java/org/spongepowered/common/mixin/api/mcp/tileentity/LockableTileEntityMixin_API.java
Show resolved
Hide resolved
| container.set(Constants.TileEntity.LOCKABLE_CONTAINER_CUSTOM_NAME, this.customName); | ||
| } | ||
| return container; | ||
| } |
There was a problem hiding this comment.
Mind the horrible code selection zone lol
There was a problem hiding this comment.
the customName string doesn't exist here any more--it was moved in vanilla.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpongeAPI | SpongeCommon
Chests now have much better logic for finding its connected chest. This PR updates the mixin's logic to match Vanilla's.
Also, LockableLootTileEntity's customName property was moved to its superclass in Vanilla. This PR also updates the mixins to reflect that change.