implement World/ServerWorld #2627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faithcaio
force-pushed
the
api8/world
branch
2 times, most recently
from
721aae5
to
d6a523b
Compare
gabizou
reviewed
May 30, 2020
src/mixins/java/org/spongepowered/common/mixin/api/mcp/world/IWorldReaderMixin_API.java
Outdated
Show resolved
Hide resolved
Faithcaio
commented
May 31, 2020
| return false; | ||
| } | ||
| default boolean setBlock(int x, int y, int z, org.spongepowered.api.block.BlockState blockState, BlockChangeFlag flag) { | ||
| return IWorldGenerationReaderMixin_API.super.setBlock(x, y, z, blockState, flag); // TODO is capture needed here? |
There was a problem hiding this comment.
@gabizou api7 code was capturing stuff in this method. Is this needed here?
Otherwise IWorldGenerationReaderMixin_API already has the redirect to the shadow$setBlockState
Faithcaio
commented
May 31, 2020
| } | ||
|
|
||
| @Override | ||
| default void setRawData(final int x, final int y, final int z, final DataView container) throws InvalidDataException { | ||
| default boolean spawnEntity(Entity entity) { |
There was a problem hiding this comment.
@gabizou api7 code was capturing stuff in this method. Is this needed here?
Otherwise IWorldWriterMixin_API already has the redirect to the shadow$addEntity
Faithcaio
force-pushed
the
api8/world
branch
3 times, most recently
from
38b5450
to
4f47a11
Compare
Faithcaio
force-pushed
the
api8/world
branch
3 times, most recently
from
c1cd684
to
cf2e539
Compare
Faithcaio
force-pushed
the
api8/world
branch
3 times, most recently
from
46c5b03
to
842adf2
Compare
Faithcaio
commented
Jun 29, 2020
src/mixins/java/org/spongepowered/common/mixin/api/mcp/world/WorldMixin_API.java
Outdated
Show resolved
Hide resolved
Faithcaio
commented
Jun 29, 2020
src/mixins/java/org/spongepowered/common/mixin/api/mcp/world/WorldMixin_API.java
Outdated
Show resolved
Hide resolved
|
Why do those mixins have the API name in their name in invalid? e.g IWorldMixin_LocationBasedDataHolder_API |
|
I separated them out to invalid so that we don't have a bunch of not implemented methods. |
Faithcaio
force-pushed
the
api8/world
branch
2 times, most recently
from
1cba7cb
to
46fc9b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.