Add string based parsing for states #3141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zidane
reviewed
Aug 29, 2020
src/main/java/org/spongepowered/common/fluid/SpongeFluidStateBuilder.java
Outdated
Show resolved
Hide resolved
dualspiral
force-pushed
the
api8/state_serialization
branch
3 times, most recently
from
7f8c3c5
to
0e18aa1
Compare
|
I think this is ready to go. The actual matcher logic is at https://github.com/SpongePowered/SpongeCommon/pull/3141/files#diff-23397afc63a4c03b7461df0f8f3db2c0eb3348cc521a89fb16a6728abf817e39R62-R83 - someone please take a look at that and make sure I've got this right before merging. |
* Remove DataSerializable from matchers * Use Mojang BlockState command parser for string block state parsing * Mimic Mojang BlockState command parser for fluids
dualspiral
force-pushed
the
api8/state_serialization
branch
from
0e18aa1
to
774dc73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpongeAPI | SpongeCommon
The initial intention was to remove
CatalogTypefromBlockStateandFluidStateand use Minecraft's inbuiltBlockStateParserto allow us to rebuild strings that represent block states. FluidState has a toned down version of the parser.There is a bigger issue in that the schematic system heavily relies on the fact that
BlockStateis a catalog type. I've not touched this - I'd rather someone else looked at that.