Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/verify overwrites #3142

Merged
merged 13 commits into from Nov 16, 2020
Merged

Fix/verify overwrites #3142

merged 13 commits into from Nov 16, 2020

Conversation

ImMorpheus
Copy link
Contributor

@ImMorpheus ImMorpheus commented Aug 29, 2020 •
edited

Verify overwrites

@ImMorpheus ImMorpheus added status: wip Work in progress version: 1.16 (u) API: 8 labels Aug 29, 2020
@ImMorpheus ImMorpheus removed the status: wip Work in progress label Nov 15, 2020
@ImMorpheus
Copy link
Contributor Author

ImMorpheus commented Nov 15, 2020 •
edited

@Zidane this should be ready. There's still an issue with the death message being shown twice but that's gonna be fixed in a separate PR.

Now the overwrites are verified and updated to 1.15.2.

Note: I haven't checked the overwrites in the invalid folder,

@ImMorpheus ImMorpheus merged commit 89f2f36 into SpongePowered:api-8 Nov 16, 2020
@ImMorpheus ImMorpheus deleted the overwrite/1.15.2 branch November 16, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zidane Zidane Awaiting requested review from Zidane

Assignees
No one assigned
Labels
version: 1.16 (u) API: 8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ImMorpheus