Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Mixin to 0.8.1 with AP fixes. Bump Modlauncher #3173

Merged
merged 1 commit into from Oct 9, 2020
Merged

Conversation

gabizou
Copy link
Member

@gabizou gabizou commented Oct 3, 2020

Some AP issues exist from the changes in Mixin 0.8.1 DO NOT MERGE YET

This is a preliminary branch PR to test the build with Mixin 0.8.1

Unfortunately, the jar does not run successfully in production due to a new AP issue related to the Mixin commit that fixed the AP resolving hierarchical methods on targets.

Undoes several previous workaround fixes for Mixin that were resolved in
0.8.1 and successively in 0.8.2.

Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
@gabizou gabizou marked this pull request as ready for review October 9, 2020 02:21
@gabizou
Copy link
Member Author

gabizou commented Oct 9, 2020

Verification of working:
logs
jar:
spongevanilla-1.15.2-8.0.0-SNAPSHOT-universal.jar.zip

@gabizou gabizou merged commit c2597b6 into api-8 Oct 9, 2020
@gabizou gabizou deleted the api8/mixin-0.8.1 branch October 9, 2020 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants