Generify Palettes Implementation #3178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cybermaxke
reviewed
Oct 5, 2020
src/main/java/org/spongepowered/common/world/schematic/ImmutableBimapPalette.java
Show resolved
Hide resolved
gabizou
force-pushed
the
api8/palettes
branch
from
39d4be9
to
5b71486
Compare
A Supplier normally would evaluate every single time being called, but in some cases, we'd rather be able to memoize the value generated from the Supplier after the first call. This is not meant to be leaked beyond memoizing global objects that are referentially transparent themselves (like an object being comprised of functions/suppliers that rely on other global variables). Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Traditionally, Mojang is appearing to want to store a BlockState as a map to better suit DFU's ability to update a state's values and properties. This map based representation however, is not ideal to being used for storage with a palette that retains the integer to string like mapping internally. It may well be possible to take advantage of DFU in the future, but at this time, a less breakage of the Schematic Specification is required. Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
gabizou
force-pushed
the
api8/palettes
branch
from
5b71486
to
d897cf7
Compare
Palettes are much more streamlined now, with global palettes being memoized functions built off the global registries (meaning they are reload-aware) while copies can be isolated by themselves and rebuilt however need be. Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
gabizou
force-pushed
the
api8/palettes
branch
from
d897cf7
to
77a6d32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpongeAPI | SpongeCommon
This will bring the implementation of Palettes to be more inline with their mutability/immutability aspects, though I still have some questions to answer:
Palettebeing built by referring to a Minecraft owned Palette (like the case of BlockStates)Palettebased on a Minecraft registry?More to come as it gets fleshed out.