Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor death message #3203

Merged
merged 1 commit into from Nov 17, 2020
Merged

Refactor death message #3203

merged 1 commit into from Nov 17, 2020

Conversation

ImMorpheus
Copy link
Contributor

@ImMorpheus ImMorpheus commented Nov 17, 2020

Changes:

  • Audience#sendMessage is moved out of SpongeCommonEventFactory#callDestructEntityEventDeath
  • event#isMessageCancelled is now compatible with Gamerule#SHOW_DEATH_MESSAGES
  • Fix Death event audience: the audience is the server, not the player.

@Zidane Zidane merged commit 220d6ca into SpongePowered:api-8 Nov 17, 2020
@ImMorpheus ImMorpheus deleted the fix/death branch November 17, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants