Refactor ChangeBlockEvent with Operations #3216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Only the BlockEventBasedTransaction will perform a post currently, but this allows for multiple transaction types to perform a "gather" based on their type of transaction. In a situation that another transaction needs to operate on a composite, this can potentially create such a composite event of several transactions. Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
This implementation pre-sorts the list of transactions into world keyed lists. There is the possibility that if a world is no longer available, the event and transactions are merely ignored. Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Pistons would freely ignore tracking without us knowing leading to some ghost TileEntities being left in the world, only to be removed on world re-load. The interesting aspect of these changes is that without changing much of the logging aspect, we're able to repeat most of the same logic as before, where we allow the block event to be added, and only after the transactions are event driven, do we "restore" the block event and cancel later by list removal. Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Entities that are spawned while ticking entities are added to a separate list in the ServerWorld. To "roll back", we can safely remove the entities from the added list and the chunk. This will allow us to safely make the modifications without triggering some other hacky workarounds. Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
gabizou
force-pushed
the
api8/changeblock-event-update
branch
from
4f31fb5
to
f8e7ab8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpongeAPI | SpongeCommon
Implementation is very straight forward.