Feature/datapack/dimension #3243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zidane
force-pushed
the
feature/datapack/dimension
branch
4 times, most recently
from
3ee30cd
to
d25a04b
Compare
Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Signed-off-by: Chris Sanders <zidane@spongepowered.org>
…orldManager... Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Still a few things to go before I can call this project complete. Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Fire ConstructWorldPropertiesEvent for the overworld if it is new. Signed-off-by: Chris Sanders <zidane@spongepowered.org>
This is a Vanilla only concept that is kept to overworld only. Signed-off-by: Chris Sanders <zidane@spongepowered.org>
This prevents world data from loading when someone has removed a world template. Vanilla spec actually stores their worlds this way to defend against the level and sublevels being affected by changes to the server.properties (mainly if the seed changes). In a future commit, I will write the Vanilla worlds to file as a template and have the file being the ultimate authority on what is read as properties. Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Update for API changes. Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Faithcaio
force-pushed
the
feature/datapack/dimension
branch
from
eebcac0
to
3817880
Compare
Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Fixing saving templates failing if the directories don't exist. Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply to follow my changes though feedback is welcomed.