notification-ticket #3314
Merged
notification-ticket #3314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabizou
force-pushed
the
notification-ticket
branch
from
0009604
to
0ebee88
Compare
gabizou
commented
Mar 8, 2021
| return Optional.of((context, frame) -> { | ||
| frame.pushCause(this.locatableBlock.get()); | ||
| }); | ||
| return Optional.of((context, frame) -> frame.pushCause(this.ticketSupplier.get())); |
There was a problem hiding this comment.
This is where I'm debating whether there should be more to the frame mutator, but as it stands, it's suiting nicely
There was a problem hiding this comment.
Like, something I could imagine being useful is:
return Optional.of((context, frame) -> {
if (parent instanceof ChangeBlock) {
frame.pushCause(((ChangeBlock) parent).original);
}
frame.pushCause(this.ticketSupplier.get());
});to populate the original changeblock being changed (may look at potentially providing the parent transaction as a BlockTransaction accessor if available)
gabizou
force-pushed
the
notification-ticket
branch
from
0ebee88
to
f2aa110
Compare
ImMorpheus
added
status: needs review
gabizou
force-pushed
the
notification-ticket
branch
2 times, most recently
from
923fb24
to
46163ab
Compare
ImMorpheus
force-pushed
the
notification-ticket
branch
from
c66cfd3
to
f0b27a9
Compare
This revamps the previously meticulous brain-ache NotifyNeighborBlockEvent into a more streamlined event similar to ChangeBlock event. As the batching system has proven useful, this can safely expose directional suppliers without explicitly relying on legacy logic of "Always notify every neighbor on a target position" Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
ImMorpheus
force-pushed
the
notification-ticket
branch
from
f0b27a9
to
3596699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API | Sponge
Implements the new NotifyNeighborBlockEvent