Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MoveEntityEvent and RotateEntityEvent implementation improvements #3754

Merged
merged 12 commits into from Sep 3, 2022
Merged

MoveEntityEvent and RotateEntityEvent implementation improvements #3754

merged 12 commits into from Sep 3, 2022

Conversation

Yeregorix
Copy link
Member

This PR includes changes from #3612 and from #3751.

To summarize:

  • Fire events for vehicles.
  • Avoid spamming events for small movements, based on a grid system.
  • Notify the client when the destination is changed.
  • Fix "moved too quickly" errors when the destination is changed.

@Yeregorix
Copy link
Member Author

Yeregorix commented Aug 27, 2022 •
edited

I'm currently testing the vehicle move event. I can barely move when I'm riding a horse. PR is not ready yet.

@Zidane Zidane merged commit 9aefa35 into SpongePowered:api-8 Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Yeregorix @Zidane @dualspiral