Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple missing slot transaction tracking + backport from 1.19 #3755

Conversation

vectrixdevelops
Copy link
Contributor

@vectrixdevelops vectrixdevelops commented Aug 27, 2022

Fixes the reported cases in #3680.

Backports 6ebd3ea.

Includes:

  • Captures player inventory transactions during an event (i.e mod adds an item to the players inventory on the forge left click event). i.e in the Storage Drawers mod where the player will interact with the block to take an item out of it (without using a GUI).
  • Captures slot transactions during a command correctly, using the example provided here Logged slot transactions without event #3680 (comment).
  • Captures inventory open and slot transactions during an open gui, this fixes cases where a mod will add items to the container as it is opening. i.e in the Storage Drawers mod where the player will shift + interact to open the GUI.
  • Fixes the slot transaction tracking to include what happens during the call to useItem. i.e interacting with an empty map to create a map.

Copy link
Contributor

@Faithcaio Faithcaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not tested, but looks good

@vectrixdevelops vectrixdevelops force-pushed the fix/missing-slot-transaction-tracking branch 3 times, most recently from ca8a25f to 1cfb124 Compare August 31, 2022 08:23
@vectrixdevelops vectrixdevelops force-pushed the fix/missing-slot-transaction-tracking branch from 1cfb124 to e546ec4 Compare August 31, 2022 08:37
@vectrixdevelops vectrixdevelops changed the title [WIP] Fix multiple missing slot transaction tracking + backport from 1.19 Fix multiple missing slot transaction tracking + backport from 1.19 Aug 31, 2022
@Zidane Zidane merged commit 6e443ec into SpongePowered:api-8 Sep 3, 2022
@vectrixdevelops vectrixdevelops deleted the fix/missing-slot-transaction-tracking branch October 15, 2022 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants