Fix block entity memory leak (API 9) #3813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can only happen when a plugin manipulates the chunks while the world is seen as empty? Which would mean this can't be reported to Mojang directly to get this fixed? Could you add more details to the comment so this is not overlooked when porting to the newer versions of Minecraft. |
Lignium
force-pushed
the
fix/block-entity-memory-leak
branch
from
674207e
to
3918823
Compare
|
@aromaa Quite right. I have added some comments. |
aromaa
requested changes
Jan 13, 2023
src/mixins/java/org/spongepowered/common/mixin/core/server/level/ServerLevelMixin.java
Outdated
Show resolved
Hide resolved
…el/ServerLevelMixin.java Co-authored-by: Joni Aromaa <me@joniaromaa.fi>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adaptation of my early PR #3689 for api-8. In version 1.18.2, the associated code has changed slightly, leaving only one field with a collection of ticking block entities. The code is tested, the leak is gone.