Fix issues with modded tile entities and lights #3838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes all the mechanical issues I had with Create vs SpongeForge. Tested on a server with forge-1.16.5-36.2.39. Nice work! |
ImMorpheus
requested changes
Apr 12, 2023
...rg/spongepowered/common/event/tracking/context/transaction/effect/UpdateLightSideEffect.java
Show resolved
Hide resolved
|
I just amended the last commit because a forgot two |
ImMorpheus
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forge adds specific methods to check whether a block has a tile entity or is emitting light. We need to use these methods instead of the vanilla ones to properly support modded blocks. Previously this was done correctly in API 7, but got lost in the update process.
This fixes issues with Create's gearbox and gearshit (#3835) and probably issues for many other mods as well.