Fix forge interactions #3844
Merged
Fix forge interactions #3844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeregorix
commented
Apr 16, 2023
forge/src/main/java/org/spongepowered/forge/hook/ForgeEventHooks.java
Outdated
Show resolved
Hide resolved
aromaa
reviewed
Apr 16, 2023
...src/mixins/java/org/spongepowered/forge/mixin/core/server/level/ServerPlayerMixin_Forge.java
Outdated
Show resolved
Hide resolved
aromaa
approved these changes
Apr 20, 2023
gabizou
approved these changes
Apr 21, 2023
This was referenced Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several issues with Forge interactions:
PlayerInteractEvent.RightClickBlockwas never fired.onItemUseFirstanddoesSneakBypassUsewere never called.InteractItemEvent.Primarywe must ensure a block or an entity is not reachable to ensure it's indeed an item interaction. The reach was invalid, ignoring bothForgeMod#REACH_DISTANCEattribute and the gamemode.For 1. , the approach here is different from what gabizou did in #3711. Instead of creating a customEventContextKeyto compensate the fact the Sponge event doesn't contain as much information as the Forge event. I decided to first create the Forge event first, then create the Sponge event from it. Also, I've made a few modifications to the dual bus system because I need to read the result of both events to properly support ForgePlayerInteractEvent#setCancellationResult.All other interactions seem to be working properly but are not using the dual bus.