Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track direct chunk access #3855

Merged
merged 1 commit into from
May 5, 2023
Merged

Track direct chunk access #3855

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 22 additions & 9 deletions ...ava/org/spongepowered/common/mixin/tracker/world/level/chunk/LevelChunkMixin_Tracker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@
import net.minecraft.world.level.chunk.LevelChunkSection;
import net.minecraft.world.level.chunk.ProtoTickList;
import net.minecraft.world.phys.AABB;
import org.apache.logging.log4j.Level;
import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
import org.checkerframework.checker.nullness.qual.NonNull;
import org.checkerframework.checker.nullness.qual.Nullable;
import org.spongepowered.api.world.BlockChangeFlags;
import org.spongepowered.asm.mixin.Final;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.Shadow;
Expand Down Expand Up @@ -65,7 +65,7 @@
import org.spongepowered.common.event.tracking.context.transaction.pipeline.ChunkPipeline;
import org.spongepowered.common.event.tracking.phase.generation.ChunkLoadContext;
import org.spongepowered.common.event.tracking.phase.generation.GenerationPhase;
import org.spongepowered.common.util.PrettyPrinter;
import org.spongepowered.common.util.Constants;
import org.spongepowered.common.world.BlockChange;
import org.spongepowered.common.world.SpongeBlockChangeFlag;

Expand All @@ -85,21 +85,34 @@ public abstract class LevelChunkMixin_Tracker implements TrackedLevelChunkBridge
@Shadow @Final private net.minecraft.world.level.Level level;

@Shadow public abstract @Nullable BlockEntity shadow$getBlockEntity(BlockPos pos, LevelChunk.EntityCreationType creationMode);
@Shadow public abstract BlockState getBlockState(BlockPos pos);
@Shadow public abstract BlockState shadow$getBlockState(BlockPos pos);
// @formatter:on
private @MonotonicNonNull PhaseContext<@NonNull ?> tracker$postProcessContext = null;

@Inject(method = "setBlockState", at = @At("HEAD"), cancellable = true)
private void tracker$sanityCheckServerWorldSetBlockState(final BlockPos pos, final BlockState state, final boolean isMoving,
private void tracker$setBlockState(final BlockPos pos, final BlockState newState, final boolean isMoving,
final CallbackInfoReturnable<BlockState> cir
) {
if (!((LevelBridge) this.level).bridge$isFake()) {
new PrettyPrinter(80).add("Illegal Direct Chunk Access")
.hr()
.add(new IllegalAccessException("No one should be accessing Chunk.setBlock in a ServerWorld's environment"))
.log(PhaseTracker.LOGGER, Level.WARN);
if (((LevelBridge) this.level).bridge$isFake()) {
return;
}

final PhaseTracker instance = PhaseTracker.getInstance();
if (instance.getSidedThread() != PhaseTracker.SERVER.getSidedThread() && instance != PhaseTracker.SERVER) {
throw new UnsupportedOperationException("Cannot perform a tracked block change on a chunk while not on the main thread!");
}

final BlockState currentState = this.shadow$getBlockState(pos);
if (currentState == newState) {
cir.setReturnValue(null);
return;
}

final SpongeBlockChangeFlag spongeFlag = (SpongeBlockChangeFlag) BlockChangeFlags.NONE.withBlocksMoving(isMoving);
final int limit = Constants.World.DEFAULT_BLOCK_CHANGE_LIMIT;

final ChunkPipeline chunkPipeline = this.bridge$createChunkPipeline(pos, newState, currentState, spongeFlag, limit);
cir.setReturnValue(chunkPipeline.processChange(instance.getPhaseContext(), currentState, newState, pos, limit));
}

/**
Expand Down