Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login plugin messages & IP forwarding #3928

Merged
merged 7 commits into from
Nov 24, 2023

Conversation

avaruus1
Copy link
Contributor

Fixes both legacy & modern ip forwarding and login plugin messages.

Resolves #3905

@aromaa aromaa self-assigned this Nov 24, 2023
@aromaa aromaa added type: bug Something isn't working system: network version: 1.20 API: 11 labels Nov 24, 2023
Copy link
Member

@aromaa aromaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Few NITs.

avaruus1 and others added 4 commits November 24, 2023 18:18
…hannelManager.java

Co-authored-by: Joni Aromaa <me@joniaromaa.fi>
…otocol/login/ServerboundCustomQueryAnswerPacketMixin.java

Co-authored-by: Joni Aromaa <me@joniaromaa.fi>
…otocol/login/ServerboundCustomQueryAnswerPacketMixin.java

Co-authored-by: Joni Aromaa <me@joniaromaa.fi>
Copy link
Member

@aromaa aromaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@aromaa aromaa merged commit 1f06478 into SpongePowered:api-11 Nov 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system: network type: bug Something isn't working version: 1.20 API: 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants