[WIP] Implementation of DominantHand #712
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @Override | ||
| public String getName() { | ||
| return this.key.replace("options.mainHand.", ""); |
There was a problem hiding this comment.
Should probably set a field with this value
ZephireNZ
force-pushed
the
feature/dominant-hand
branch
from
627ce1d
to
111898c
Compare
Fix hand setting Progress on new handedness
ZephireNZ
force-pushed
the
feature/dominant-hand
branch
from
111898c
to
10cbe98
Compare
|
Accidentally deleted the branch in my pruning, oops! |
|
@ZephireNZ Do you plan to update this bad boy? If not I can handle it. |
|
Go for it, not really had the time for Sponge recently :/ |
Closed
ImMorpheus
added
status: needs updating
|
Superseded #2105 |
ImMorpheus
added
resolution: superseded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #630
SpongePowered/SpongeAPI#1121
This implements the new
HandTypemanipulator, with potential for mods to add arbitrary hands later with Forge.Test Plugin code:
COMING SOON TO A THEATRE NEAR YOU