Add features specific to Shulkers, ShulkerBullets and ShulkerBoxes. #1903
Conversation
Also added EntityTargetingProjectile to abstract ShulkerBullet targeting.
|
~qa |
|
Links are broken here and in common |
| * | ||
| * @return the direction of this bullet. | ||
| */ | ||
| Direction getDirection(); |
There was a problem hiding this comment.
Can be default implemented.
There was a problem hiding this comment.
What should I put in the default implementation? There is no data for it in Entity.
And I'm wondering if it would be better to expose the Direction through the Data API instead of a getter.
There was a problem hiding this comment.
Oh, I thought you already exposed DirectionalData for the bullet as well
There was a problem hiding this comment.
Can very well expose directional data on the bullet.
| * | ||
| * @see TargetedEntityData#value | ||
| */ | ||
| public static final Key<OptionalValue<Entity>> TARGETED_ENTITY = DummyObjectProvider.createExtendedFor(Key.class,"TARGETED_ENTITY"); |
There was a problem hiding this comment.
Why is this an optional value? If there's no targeted entity, then the value shouldn't exist. Inversely, the value should only be returned as a valid value if there's a targeted entity (so you can support removing the targeted entity).
| * | ||
| * @return the direction of this bullet. | ||
| */ | ||
| Direction getDirection(); |
There was a problem hiding this comment.
Can very well expose directional data on the bullet.
…getDirection by a DirectionalData
There was a problem hiding this comment.
Leaving a decision for @Cybermaxke to make about targeted entity pointing to Entity references. Otherwise, the PR looks fine.
SpongeAPI | SpongeCommon
This PR adds everything I found for Shulkers and its derived products.
I only have a doubt about
ShulkerBullet#getDirection, as it may be a DirectionalData.Reviews are welcome.
Test Plugin
Fixes #1901