Create a SubjectProxy and separate CommandCause from CommandContext #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This actually doesn't change much, but it was actually a problem in our implementation. It makes sense to keep it separate, and all the standard tasks can still be done in the same way (the context is now a SubjectProxy and you can easily send a message from it)
This was referenced Jan 9, 2022
build: Update dependency org.spongepowered:spongeapi to v8
IntellectualSites/FastAsyncWorldEdit#1531
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic premise is that
CommandContextandCommandContext.Builderno longer implementCommandCause.I basically shouldn't have done this anyway, but the idea was that a
CommandContextcould functionally act as aCommandCauseas a convenience to them. However, in implementation, there is an assumption that aCommandSourceis aCommandCause, which is true. The opposite isn't necessarily true, however, and I've bumped up places where I've made this bad assupmption.What I have opted to do is stop
CommandContextand its builder from implementingCommandCause, but to continue helping plugin devs, it now implements the newSubjectProxyinterface and continues to have thesendMessage(Component)method. So, if you need aCommandCauseyou have to explicity get it, but if you wanted to do a permission check and/or send a message (two very common things), this can be done via the context.I do want to merge this soon because I'm working on Selectors and that does rely on this, but I'm using the PR as a sanity check for style and such.