fix: WorldTemplates #2503
Merged
fix: WorldTemplates #2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Expose and unify the data properties between WorldType and WorldTypeTemplate - Remove the type getter from template. This prompts a much larger discussion about data packs but templates should never reference their actual built type. It is an implementation detail and the API should declare these as temporary, lifecycle-like objects. Signed-off-by: Chris Sanders <zidane@spongepowered.org>
This needs a far better fix in 11 but that comes with looking over DataPack objects as a whole. Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sponge | SpongeAPI
This is to support the fixes as we are technically supporting API 10 for a little while longer.