Add command interfaces #29
Conversation
| /** | ||
| * | ||
| */ | ||
| public interface CommandSource { |
There was a problem hiding this comment.
What does this interface do ?
There was a problem hiding this comment.
It represents the source of the command. (e.g. Player or Console)
There was a problem hiding this comment.
Hmm wouldn't it be better to use CommandSender as name? Like in NMS ?
There was a problem hiding this comment.
I like CommandSource better, dont forget this is not a bukkit copy
|
Maybe CommandSource like sender for now. When execute command, run like this: public void execute(CommandSource cmd, String[] args){
} |
|
@nikosgram13: What do you mean by "Maybe CommandSource like sender"? |
|
Zidane mentioned he was planning a more "meaty" command system and I think with sk's recent work on Intake, and sk's desire for a non-crappy permission system, I'm betting that they'll want to tackle this. |
|
Here's a link to Intake: https://github.com/sk89q/Intake We'll have to discuss the equivalent to "CommandSender" though. |
|
@sk89q Intake looks sexy |
|
I prefer I like where intake is going, and I like the use of the annotation-based command registration. One feature that's critical to me, and the only reason I didn't look into intake further, is we should allow a parent command to still handle logic if the next argument doesn't match any of it's children, rather catching a thrown exception as a place to present the logic. |
Zidane
force-pushed
the
master
branch
2 times, most recently
from
c368a6d
to
b1babf2
Compare
kitskub
force-pushed
the
master
branch
2 times, most recently
from
fc421d8
to
74766ec
Compare
|
duplicated by #31 |
|
@botskonet Agreed, like i mentioned in the first commit |
| import java.util.List; | ||
|
|
||
| /** | ||
| * |
| * @return List of command aliases | ||
| */ | ||
| List<String> getAliases(); | ||
|
|
|
I ended up writing the command interfaces myself, sorry! See 8779e58. |
Adding some interfaces for commands.
I am open to suggestions on this pull request.