Fix javadocs for MessageSinks#combined and MessageSinkFactory#combined #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see no reason not to merge this PR. |
|
This really belongs in the minor issues list. Looks fine to me |
|
Move this to the OCD issue #221 and we'll take care of it when someone makes another pass before next release. |
9 tasks
simon816
added a commit
that referenced
this pull request
Jul 13, 2015
* GenericArguments.none() should return a static CommandElement instead of rebuilding it every time. * GameMode javadoc uses fully qualified link to Player * Ban.User#getUser wrong return type * Some method declarations in DataHolder are generic although they don't have to. This leads to worse usability / more raw casts. * Documentation for Direction#getClosest(Vector3d) is incorrect * Clean up some javadocs for MessageSinks#combined and MessageSinkFactory#combined. See #727 * CommandFlags:161 should be marked with $FALL-THROUGH$ * ItemStackBuilder#fromItemStack should not create a new builder * DisplacementProperty has wrong javadocs. * PlayerResourcePackStatusEvent is in the wrong package should be in api.event.entity.player not api.event.entity.living.player * Don't define the kick message * SpongeEventFactory:1893 and SpongeEventFactory:1907 should be 'Creates' not 'Create' * GameMode would be better suited in the org.spongepowered.api.data.type package. * ProjectileSource should return Optional<Projectile> in case it was not spawned. * UnknownProjectileSource could be a singleton, ProjectileSource.UNKNOWN * AbstractInventoryProperty could extend AbstractProperty. * Methods from Preconditions should be imported statically * interactBlock should take a Direction parameter. * Fix some raw types and @SuppressWarnings
simon816
added a commit
that referenced
this pull request
Jul 13, 2015
* GenericArguments.none() should return a static CommandElement instead of rebuilding it every time. * GameMode javadoc uses fully qualified link to Player * Ban.User#getUser wrong return type * Documentation for Direction#getClosest(Vector3d) is incorrect * Clean up some javadocs for MessageSinks#combined and MessageSinkFactory#combined. See #727 * CommandFlags:161 should be marked with $FALL-THROUGH$ * ItemStackBuilder#fromItemStack should not create a new builder * DisplacementProperty has wrong javadocs. * PlayerResourcePackStatusEvent is in the wrong package should be in api.event.entity.player not api.event.entity.living.player * Don't define the kick message * SpongeEventFactory:1893 and SpongeEventFactory:1907 should be 'Creates' not 'Create' * ProjectileSource should return Optional<Projectile> in case it was not spawned. * UnknownProjectileSource could be a singleton, ProjectileSource.UNKNOWN * AbstractInventoryProperty could extend AbstractProperty. * Methods from Preconditions should be imported statically * interactBlock should take a Direction parameter. * Fix some raw types and @SuppressWarnings
simon816
added a commit
that referenced
this pull request
Jul 13, 2015
* GenericArguments.none() should return a static CommandElement instead of rebuilding it every time. * Ban.User#getUser wrong return type * Documentation for Direction#getClosest(Vector3d) is incorrect * Clean up some javadocs for MessageSinks#combined and MessageSinkFactory#combined. See #727 * CommandFlags:161 should be marked with $FALL-THROUGH$ * ItemStackBuilder#fromItemStack should not create a new builder * DisplacementProperty has wrong javadocs. * PlayerResourcePackStatusEvent is in the wrong package should be in api.event.entity.player not api.event.entity.living.player * Don't define the kick message * SpongeEventFactory:1893 and SpongeEventFactory:1907 should be 'Creates' not 'Create' * ProjectileSource should return Optional<Projectile> in case it was not spawned. * UnknownProjectileSource could be a singleton, ProjectileSource.UNKNOWN * Methods from Preconditions should be imported statically * interactBlock should take a Direction parameter. * Fix some raw types and @SuppressWarnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transform-->transformMessagesink(array) -->sinks