Skip to content

Commit

Permalink
Remove avatar_url from SSO payload
Browse files Browse the repository at this point in the history
  • Loading branch information
lukegb committed Jan 17, 2017
1 parent 1f73aaa commit 92c6482
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 16 deletions.
12 changes: 0 additions & 12 deletions spongeauth/sso/tests/test_make_payload.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,25 +12,13 @@ def setup(self):
self.request = unittest.mock.MagicMock()
self.request.build_absolute_uri.return_value = 'http://www.example.com/example.jpg'

def test_avatar_url(self):
user = accounts.tests.factories.UserFactory.create()
avatar = accounts.tests.factories.AvatarFactory.create(user=user)
user.current_avatar = avatar
user.save()

payload = utils.make_payload(user, 'nonce-nce', self.request)
self.request.build_absolute_uri.assert_called_once_with(avatar.remote_url)
assert payload['avatar_url'] == 'http://www.example.com/example.jpg'

def test_builds_payload(self):
user = accounts.tests.factories.UserFactory.build()

payload = utils.make_payload(user, 'nonce-nce', self.request)
assert payload == {
'nonce': 'nonce-nce',
'email': user.email,
'avatar_force_update': 'true',
'avatar_url': 'http://www.example.com/example.jpg',
'custom.user_field_1': user.mc_username,
'custom.user_field_2': user.gh_username,
'custom.user_field_3': user.irc_nick,
Expand Down
2 changes: 0 additions & 2 deletions spongeauth/sso/tests/test_send_update_ping.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ def test_send_update_ping(settings):
'external_id': 10101,
'username': 'foo_',
'name': 'foo_',
'avatar_url': user.avatar.get_absolute_url(),
'avatar_force_update': 'true',
'custom.user_field_1': 'meep',
'custom.user_field_2': 'meeep',
'custom.user_field_3': 'XxXmeepXxX'})
2 changes: 0 additions & 2 deletions spongeauth/sso/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ def make_payload(user, nonce, request=None):
'external_id': user.pk,
'username': user.username,
'name': user.username,
'avatar_url': avatar_url,
'avatar_force_update': 'true',
'custom.user_field_1': user.mc_username,
'custom.user_field_2': user.gh_username,
'custom.user_field_3': user.irc_nick,
Expand Down

0 comments on commit 92c6482

Please sign in to comment.