Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SlotTransactions from other viewers of containers are included in your slot transactions #1133

Closed
parlough opened this issue Jan 14, 2017 · 1 comment
Closed

SlotTransactions from other viewers of containers are included in your slot transactions #1133

parlough opened this issue Jan 14, 2017 · 1 comment
Assignees
@Aaron1011

Comments

@parlough
Copy link
Contributor

parlough commented Jan 14, 2017 •
edited
Loading

So there is a duplication bug with our locking plugin Latch. We have a donation chest which only people who are added to can remove from but everyone can add to. How it works is basically the people who are not the owner or added as an accessor cannot remove items, move them, or similar. The problem arises when someone without access is viewing someone with access removing items. Once the person without access tries to move an item out or similar we cancel the event, and for some reason the items removed are replaced into the container creating a duplicate.

It seems like for some reason the person simply viewing the transactions also has the original player's slot transactions within theirs. There may be a reason for this but to me that does not seem intentional.

Find our code for this ClickInventoryEvent listener here.

Sponge versions where this has occurred.

First:
spongeforge-1.10.2-2171-5.1.0-BETA-2010

Second:
SpongeAPI: 6.0.0-SNAPSHOT-9005019
SpongeVanilla: 1.11.2-6.0.0-BETA-192
@Faithcaio
Copy link
Contributor

might be related to: #1105

@Aaron1011 Aaron1011 self-assigned this Jan 28, 2017
Aaron1011 added a commit that referenced this issue Jan 28, 2017
@Aaron1011
Only capture inventory changes during click packets
3ba0531 
Closes #1133

At some point, we may want to fire events for changes to inventories
made outside of click packets (during world ticks, for example).
However, this is not properly implemented atm, and having capturing on
continuously leads to problems when multiple players interact with an
inventory.
Aaron1011 added a commit that referenced this issue Jan 28, 2017
@Aaron1011
Only capture inventory changes during click packets
074b0b0 
Closes #1133

At some point, we may want to fire events for changes to inventories
made outside of click packets (during world ticks, for example).
However, this is not properly implemented atm, and having capturing on
continuously leads to problems when multiple players interact with an
inventory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aaron1011 Aaron1011

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Aaron1011 @Faithcaio @parlough