Advancements implementation #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parlough
added
status: wip
Cybermaxke
force-pushed
the
feature/advancements
branch
from
f217be9
to
1f83ce7
Compare
gabizou
reviewed
Dec 27, 2017
| @@ -66,13 +76,13 @@ | |||
|
|
|||
| @Shadow @Nullable public Advancement parent; | |||
| @Shadow @Final private ResourceLocation id; | |||
| @Shadow @Final private String[][] requirements; | |||
There was a problem hiding this comment.
Are these no longer final? Or are you mutating them later with the added AT? In all honesty, you could still set them internally because @Mutable and @Final still allows you to set these values within code. The only time you realistically have to mark them as non final is if you want to make a method overridable. Unless I'm mistaken and @Mumfrey can correct me on the statement above.
There was a problem hiding this comment.
I am not very familiar with all the available features in mixin, that's why I used the AT. I replaced most of the AT entries with @Mutable fields in the latest commit.
Cybermaxke
force-pushed
the
feature/advancements
branch
from
4fd2255
to
5e12b9a
Compare
Cybermaxke
changed the title
…ated in JSON using a extra trigger_times entry.
Cybermaxke
force-pushed
the
feature/advancements
branch
from
512ca54
to
b917de7
Compare
gabizou
added a commit
that referenced
this pull request
Dec 31, 2017
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API | Common | Forge | Vanilla
This is the implementation of the advancements API.