Advancements implementation #1913
Conversation
| // In a development environment are the resources and classes separated | ||
| // into two source directories, at least in IntelliJ. | ||
| // This is a temporary fix to make sure that advancement/recipe files | ||
| // are loaded in the IDE. |
There was a problem hiding this comment.
I would love some input on this ugly fix, no idea how to work around it.
There was a problem hiding this comment.
Is this for SpongeForge itself or for Sponge plugins loaded from the classpath?
There was a problem hiding this comment.
Sponge plugins loaded from the classpath.
There was a problem hiding this comment.
Generally, we set inheritOutputDirs = true for all IntelliJ IDEA modules, which makes IntelliJ IDEA write classes and resources into one shared output directory. This is applied automatically for SpongeAPI and the Sponge implementation modules and all plugins using SpongeGradle.
However, I noticed that it wasn't applied to testplugins which might be the reason for the problem if that's what you were testing with. I fixed that in SpongePowered/SpongeAPI@2589078, can you check if your workaround is still necessary after this commit?
If you are using a separate plugin for testing, make sure to apply the SpongeGradle plugin.
There was a problem hiding this comment.
That worked, thanks! :)
Cybermaxke
force-pushed
the
feature/advancements
branch
from
176c387
to
8ee4d31
Compare
Cybermaxke
changed the title
Cybermaxke
force-pushed
the
feature/advancements
branch
from
8ee4d31
to
4767dd5
Compare
…try events. Merges #1913. Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
API | Common | Forge | Vanilla