Config Comment Cleanup #1803
Merged
Config Comment Cleanup #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly focused on bringing comment formatting and rewriting things that weren't clear. Fixed a few typos here and there and generally tried to make everything more consistent.
phit
added
type: enhancement
phit
force-pushed
the
refactor/configs
branch
2 times, most recently
from
9b90e94
to
5a43cbe
Compare
true/false > enabled/disabled 'asynchronously'
phit
force-pushed
the
refactor/configs
branch
from
5a43cbe
to
6add92c
Compare
Removed config for a feature that was removed mid 2016 SpongePowered@a1ac6cc#diff-4e6f4ff49ad98848b830a9c9b425940c
bloodmc
pushed a commit
that referenced
this pull request
Feb 19, 2018
* First pass of the big config cleanup Mainly focused on bringing comment formatting and rewriting things that weren't clear. Fixed a few typos here and there and generally tried to make everything more consistent. * Some suggestions by Inscrutable true/false > enabled/disabled 'asynchronously' * Some more cleanup Removed config for a feature that was removed mid 2016 a1ac6cc#diff-4e6f4ff49ad98848b830a9c9b425940c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct comparison of old and new config: https://gist.github.com/phit/589be51da2a2a024b0f9c3dff0c903f0/revisions
Mainly focused on comment formatting and rewriting things that weren't clear. Fixed a few typos here and there and generally tried to make everything more consistent.
Needs review and if anyone has any suggestions let me know, ill be happy to rewrite more and comment literally every setting if that's wanted.
Also includes setting
deny-chunk-requeststo false on Spongeforge, as per SpongePowered/SpongeForge#2003This goes with SpongePowered/SpongeDocs#663, which I will update to these changes once this gets pulled.