Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update configuration page and add deny-chunk-requests to the optimization page #663

Merged
merged 2 commits into from Feb 20, 2018
Merged

Update configuration page and add deny-chunk-requests to the optimization page #663

merged 2 commits into from Feb 20, 2018

Conversation

phit
Copy link
Contributor

@phit phit commented Feb 15, 2018 •
edited

In prep for SpongePowered/SpongeForge#2003
Also updated the rest of the missing entries that were added to the global.conf recently and some time ago

@Zidane gimme config nowᵖˡᵉᵃˢᵉ

ST-DDT
ST-DDT reviewed Feb 15, 2018
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR WIP (as your request hints) or will it be extended later on?

source/server/management/performance-tweaks.rst Outdated
}

When this option is enabled, mods requesting areas to be loaded to perform various tasks will be denied. Only players
and specific world generation calls will be allowed to load new chunks.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new line at the end of file.

@phit
Copy link
Contributor Author

phit commented Feb 15, 2018

well the PR is pretty much done, just waiting for that change to make it to release before this can be merged

@Inscrutable Inscrutable added the API not ready The API/code is not yet ready so we cannot merge this in yet label Feb 16, 2018
@Inscrutable Inscrutable added this to the v7.X milestone Feb 16, 2018
@phit phit mentioned this pull request Feb 16, 2018
Merged
@phit phit added needs review The submission is ready and needs to be reviewed and removed API not ready The API/code is not yet ready so we cannot merge this in yet labels Feb 19, 2018
@phit
Copy link
Contributor Author

phit commented Feb 19, 2018

SpongePowered/SpongeForge#2003 got merged and is live, so I've updated to latest config

let me know when its ready to merge and ill squash the commits

ST-DDT
ST-DDT approved these changes Feb 19, 2018
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should remove the trailing whitespaces to reduce the total diff. But thats just a minor thing. Its okay if it consistent with past/future commits.

@phit
Copy link
Contributor Author

phit commented Feb 19, 2018

I added trailing spaces to the actual config, so all future changes will have those to. Its nice when you copy parts of the config, just need to remove the line break and you have the sentences properly spaced out.

@Inscrutable
Copy link
Member

I'm happy with it, as it's pretty much 1:1 with the current Sponge config file. Any further cleanup will have to happen there anyway. By the way, you don't have to worry about squashing. It automatic at this end when kronk pull lever.

@Inscrutable Inscrutable removed the needs review The submission is ready and needs to be reviewed label Feb 20, 2018
@Inscrutable Inscrutable merged commit a2054db into SpongePowered:stable Feb 20, 2018
@phit phit deleted the config-updates branch February 20, 2018 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phit @Inscrutable @ST-DDT