Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immutability of Configurate's ConfigurationOptions unclear. #553

Closed
windy1 opened this issue Nov 20, 2016 · 0 comments
Closed

Immutability of Configurate's ConfigurationOptions unclear. #553

windy1 opened this issue Nov 20, 2016 · 0 comments
Assignees
Labels
low priority Small issues like typos that don't have much of an impact

Comments

@windy1
Copy link
Contributor

windy1 commented Nov 20, 2016

There is no mention of how the ConfigurationOptions class is actually immutable and there is no indication that it is immutable from the example code. A note or something should be added indicating the class is immutable.

https://docs.spongepowered.org/master/en/plugin/configuration/serialization.html

@windy1 windy1 changed the title Immutability of Configurate's ConfigurationOptions unclear.` Immutability of Configurate's ConfigurationOptions unclear. Nov 20, 2016
@ST-DDT ST-DDT self-assigned this Oct 14, 2018
@ST-DDT ST-DDT added the low priority Small issues like typos that don't have much of an impact label Oct 14, 2018
ST-DDT added a commit that referenced this issue Nov 16, 2018
* Move serializable types list to the serialization page
* Add stronger links between config pages and text pages.
* Add more javadoc references
* Mention default and recommended config format on the loaders page.
* Improve loading a default config from the plugin jar file example
* Mention also mention the other supported file formats in the loaders page
* Mention `@DefaultConfig` in conjunction with `ConfigurationLoader`s
* Expand the documentation on ConfigSerializable types
* Mention immutability of ConfigurationOptions. Fixes #553
* Various improvements to the config docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority Small issues like typos that don't have much of an impact
Projects
None yet
Development

No branches or pull requests

2 participants