Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpongeCommon/SpongeForge command changes #618

Closed
Grinch opened this issue Aug 14, 2017 · 8 comments
Closed

SpongeCommon/SpongeForge command changes #618

Grinch opened this issue Aug 14, 2017 · 8 comments
Assignees
Labels
outdated docs The API has changed and the docs are outdated
Projects
Milestone

Comments

@Grinch
Copy link
Contributor

Grinch commented Aug 14, 2017

Just wanted to note a few changes to the /sponge plugins command.

As of now SpongeCommon uses pagination for the plugin command to display installed plugins. On SpongeCommon/SpongeVanilla it forces Minecraft, MCP, SpongeAPI, and Sponge at the beginning of the list in that order. The console will display a non-paginated list for this command.

SpongeForge filters out mods from the /sponge plugins command and added a new command /sponge mods which will display all mods. This forces Minecraft, MCP, FML, MinecraftForge, SpongeAPI, and Sponge at the beginning of the list in that order. The console also displays a non-paginated list for this command. This command uses the permission sponge.command.mods.

Both commands also make use of tooltips for each listed item that allow you to hover over the plugin/mod and see the ID and Version quickly. Clicking it still acts the same by showing a more detailed output of the plugin/mod's properties.

tl;dr: /sponge plugins now is a paginated list when sent to players. Filters out mods on SpongeForge. SpongeForge added /sponge mods which displays installed mods and uses the permission sponge.command.mods

@Inscrutable
Copy link
Member

Which versions of SpongeAPI does this affect (ie. is it being cherry-picked to older versions)?

@Grinch
Copy link
Contributor Author

Grinch commented Aug 15, 2017

The only version I targeted for this is 7. It could be pulled into older versions but that isn't something I personally plan to PR.

@Inscrutable Inscrutable added this to the v7.0.0 milestone Aug 16, 2017
@ryantheleach ryantheleach added this to Triage in API7 via automation Nov 21, 2017
@ryantheleach ryantheleach moved this from Triage to Issue Identified in API7 Nov 21, 2017
@parlough parlough self-assigned this May 8, 2018
@parlough
Copy link
Contributor

parlough commented May 8, 2018

I'll be working on an API 7 cleanup soon. Summer break here I come.

@ryantheleach
Copy link
Contributor

In addition:

https://docs.spongepowered.org/stable/en/server/spongineer/commands.html#sponge

Needs to be double checked against https://github.com/SpongePowered/SpongeCommon/blob/stable-7/src/main/java/org/spongepowered/common/command/SpongeCommandFactory.java#L175

The blockinfo and entityinfo are missing, maybe others?

@ST-DDT
Copy link
Member

ST-DDT commented Aug 4, 2018

@parlough Status?

@ST-DDT
Copy link
Member

ST-DDT commented Aug 21, 2018

@parlough Do you mind if I take over?

@ST-DDT
Copy link
Member

ST-DDT commented Aug 22, 2018

Note to self: The following commands are not or wrongly listed:

Missing

  • /sponge blockinfo
  • /sponge entityinfo
  • /sponge which
  • /callback

Changed

  • /sponge help -> /help

@Inscrutable
Copy link
Member

The callback command is exclusively used by plugins, so that's probably all that needs to be said about it.

@ST-DDT ST-DDT added the outdated docs The API has changed and the docs are outdated label Aug 23, 2018
Inscrutable pushed a commit that referenced this issue Aug 25, 2018
* Document missing commands and permissions. Fixes #618. Fixes #722

* Cleanup

* Fix comments

* Change title to disambiguate it from plugin commands in the search

* Rename to Commands and Permissions
@Inscrutable Inscrutable moved this from Issue Identified to Pending Release in API7 Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outdated docs The API has changed and the docs are outdated
Projects
API7
  
Pending Release
Development

No branches or pull requests

5 participants