-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin Meta stuff #580
Plugin Meta stuff #580
Conversation
A preview for this pull request is available at https://cdn.rawgit.com/Spongy/SpongeDocs-PRs/1042636/. Here are some links to the pages that were modified:
Since the preview frequently changes, please link to this comment, not to the direct url to the preview. |
source/plugin/plugin-meta.rst
Outdated
dependencies = {@Dependency(id = "otherplugin", optional = true)}) | ||
|
||
For every ``@Dependency`` you provide, you may also give a ``version`` attribute specifying a `maven version range | ||
<https://docs.oracle.com/middleware/1212/core/MAVEN/maven_version.htm#MAVEN8903>`_ like ``[1.3,)`` for ``Version 1.5 or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might make more sense to link to the Javadocs of Dependency.version
here https://jd.spongepowered.org/5.0.0/org/spongepowered/api/plugin/Dependency.html#version--
A rolling PR gathers no FLARD. What's the status of this at present? |
Oh dear. Where is our esteemed @Saladoc and what will become of this PR? |
From my point of view (feel free to ignore), I don't think the Code Modularisation page is complete enough to merge, certainly, and isn't really anything to do with modularisation in itself, though the document there can be of use if you do modularise in a certain way. Modularisation of code can take many many forms, one of which is splitting up into multiple plugins. I feel like the current Code Modularisation page would be better being part of an "Interacting with Other Plugins/Plugin Interop" page (#228), because that's all you've got there so far. As for the plugin meta page, I think the changes there are reasonable. |
There's just not enough, and it's not quite on-topic anyway.
taken over from #516
sadly I screwed up the branch naming but as there is no longer a "master" branch here, I've decided to ignore it and just delete the branch afterwards.
I have tried to adress the concerns voiced in the original PR in order to not let the contributions of @20zinnm go stale.