Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Meta stuff #580

Merged
merged 13 commits into from
Feb 17, 2018
Merged

Plugin Meta stuff #580

merged 13 commits into from
Feb 17, 2018

Conversation

ghost
Copy link

@ghost ghost commented Feb 16, 2017

taken over from #516

sadly I screwed up the branch naming but as there is no longer a "master" branch here, I've decided to ignore it and just delete the branch afterwards.

I have tried to adress the concerns voiced in the original PR in order to not let the contributions of @20zinnm go stale.

@ghost ghost added FLARD This is gathering dust input wanted We would like to hear your opinion needs review The submission is ready and needs to be reviewed labels Feb 16, 2017
@ghost ghost self-assigned this Feb 16, 2017
@ghost ghost mentioned this pull request Feb 16, 2017
@Spongy
Copy link

Spongy commented Feb 16, 2017

A preview for this pull request is available at https://cdn.rawgit.com/Spongy/SpongeDocs-PRs/1042636/.

Here are some links to the pages that were modified:

Since the preview frequently changes, please link to this comment, not to the direct url to the preview.

dependencies = {@Dependency(id = "otherplugin", optional = true)})

For every ``@Dependency`` you provide, you may also give a ``version`` attribute specifying a `maven version range
<https://docs.oracle.com/middleware/1212/core/MAVEN/maven_version.htm#MAVEN8903>`_ like ``[1.3,)`` for ``Version 1.5 or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might make more sense to link to the Javadocs of Dependency.version here https://jd.spongepowered.org/5.0.0/org/spongepowered/api/plugin/Dependency.html#version--

@Inscrutable
Copy link
Member

A rolling PR gathers no FLARD. What's the status of this at present?

@Inscrutable
Copy link
Member

Oh dear. Where is our esteemed @Saladoc and what will become of this PR?
Is this complete enough to merge, or are there any spare brains in the gallery that could pick up the pieces here (again) and try to get this stuff finished?

@dualspiral
Copy link
Contributor

From my point of view (feel free to ignore), I don't think the Code Modularisation page is complete enough to merge, certainly, and isn't really anything to do with modularisation in itself, though the document there can be of use if you do modularise in a certain way. Modularisation of code can take many many forms, one of which is splitting up into multiple plugins. I feel like the current Code Modularisation page would be better being part of an "Interacting with Other Plugins/Plugin Interop" page (#228), because that's all you've got there so far.

As for the plugin meta page, I think the changes there are reasonable.

There's just not enough, and it's not quite on-topic anyway.
@Inscrutable Inscrutable removed input wanted We would like to hear your opinion needs review The submission is ready and needs to be reviewed labels Feb 17, 2018
@Inscrutable Inscrutable self-assigned this Feb 17, 2018
@Inscrutable Inscrutable changed the title Add Code Modularization Plugin Meta stuff Feb 17, 2018
@Inscrutable Inscrutable merged commit 912c2d9 into stable Feb 17, 2018
@Inscrutable Inscrutable deleted the master branch February 17, 2018 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FLARD This is gathering dust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants