Unexpected spawn location using modded portals

[waggz81]

I am currently running

• SpongeForge version: spongeforge-1.12.2-2611-7.1.0-BETA-2918 works as expected, issue starts occurring with 2920, verified still an issue with 2931 and 2944
• Forge version: forge-1.12.2-14.23.2.2623-universal.jar
• Java version: java-1.8.0-openjdk-1.8.0.161-0.b14.el7_4.x86_64
• Operating System: CentOS Linux release 7.4.1708 (Core)

• Plugins/Mods:

/sponge plugins
[14:01:33] [Server thread/INFO]: Plugins (5): Minecraft, Minecraft Coder Pack, SpongeAPI, SpongeForge, MMCReboot
/sponge mods
[14:01:37] [Server thread/INFO]: Mods (126): Minecraft, Minecraft Coder Pack, Forge Mod Loader, Minecraft Forge, SpongeAPI, SpongeForge, /dank/null, AE2 Stuff, AbyssalCraft, Actually Additions, Advanced Rocketry, Advanced Rocketry Core, AppleSkin, Applied Energistics 2, Aroma1997's Dimensional World, Aroma1997Core, Astral Sorcery, BC Builders, BC Energy, BC Factory, BC Robotics, BC Silicon, BC Transport, BD Lib, Bad Wither No Cookie! Reloaded, Baubles, Better Builder's Wands, Binnie Core, Binnie's Botany, Binnie's Design, Binnie's Extra Bees, Binnie's Extra Trees, Binnie's Genetics, Blockcraftery, Bookshelf, Botania, BuildCraft, BuildCraft Lib, Chameleon, Chisel, Chisels & Bits, CoFH Core, CoFH World, CodeChicken Lib, Compact Machines 3, Cooking for Blockheads, CraftTweaker JEI Support, CraftTweaker2, Cyclops Core, Dark Utilities, Diet Hopper, ET Lunar, EluCore, EluLib, Embers, EnderStorage, Environmental Tech, EvilCraft, EvilCraft-Compat, Exchangers, Extra Utilities 2, FTBLib, FTBUtilities, Fairy Lights, Flux Networks, Forestry, GenDustry, Gravestone Mod, Harvest, Harvest Tweaks, Industrial Foregoing, Inventory Tweaks, Iron Backpacks, Iron Chest, JEI Bees, JourneyMap, Just Enough Items, MTLib, MagicBees, MalisisCore, MalisisDoors, Mantle, Mekanism, MekanismGenerators, MekanismTools, Mod Tweaker, Morpheus, OpenBlocks, OpenModsLib, OpenModsLib Core, Pam's HarvestCraft, Placebo, Plants, ProjectE, Quick Leaf Decay, RFTools, RFTools Control, RFTools Dimensions, Redstone Flux, Reliquary, Roots 2, Rustic, Shadowfacts' Forgelin, SonarCore, Soul Shards - The Old Ways, Storage Drawers, Tesla Core Lib, Tesla Core Lib Registries, The Twilight Forest, Thermal Cultivation, Thermal Dynamics, Thermal Expansion, Thermal Foundation, TickProfiler, Tinkers' Construct, TorchMaster, UniDict, Valkyrie Lib, Vulpes library, Waila, WanionLib, Waystones, Wireless Crafting Terminal 2, Xtones, mob_grinding_utils, p455w0rd's Library

Issue Description
For Aroma1997s Dimensional World, after sponge version 2920 when using the portal to travel between dimensions the player ends up at the same Y level as the portal in the source world, for instance if I enter a portal at Y level 64 in the overworld I end up underground in the mining dimension at Y level 64. If I dig my way up to the surface portal in the mining dimension at Y level 80 and enter it, I am teleported above the portal in the overworld at Y level 80.

Logs from sponge 2920:
https://gist.github.com/waggz81/6ff541d250678201d66a3e988235207f

[ProsperCraft]

We are having this same problem with the Caverns portals.

People keep getting killed by ending up inside the ground.

[3TUSK]

I am experiencing the same issue when entering Twilight Forest with the following setup:

• MinecraftForge 1.12.2-14.23.2.2624
• Twilight Forest 1.12.2-3.6.364
• SpongeForge 1.12.2-2611-7.1.0-BETA-2931 (or 1.12.2-2611-7.1.0-BETA-2920; 1.12.2-2611-7.1.0-BETA-2918 does not have this issue)
• macOS High Sierra 10.13.3
• Java(TM) SE Runtime Environment (build 1.8.0_144-b01)

Entering twilight forest will throw player entity into mid-air, and no portal for way back would be created; if manually create one and step into it, player will be teleported to the same coordinate within overworld.

With info provided by OP, I suspect that SpongePowered/Sponge@36a7746 is the cause (which was introduced in build 2020), however I haven't conduct further researches/debugging and thus cannot be 100% sure.

Edit I: add OS and JRE info.

[liach]

@3TUSK You are for sure wrong. That commit only exists on the bleeding branch while you test with a stable-7 build.

[phit]

@liach SpongePowered/Sponge@38fdfdc no?

[liach]

Oh. that's a cherry pick, so that first commit isn't shown to be on stable 7

[ProsperCraft]

May want to change the topic to -
Unexpected spawn location when using any mods portals to other dims.

We are having problems with Caverns 2, Twilight, and changing dims with the signpost mod.

[phit]

changed the title, I can confirm this happens with pretty much any kind of modded portal

[ProsperCraft]

Tested - Fixed the issue with Caverns 2 thank you!