Skip to content
This repository has been archived by the owner on Feb 27, 2024. It is now read-only.

Techgun not supported by Sponge. #2139

Closed
RaiKave opened this issue May 11, 2018 · 6 comments
Closed

Techgun not supported by Sponge. #2139

RaiKave opened this issue May 11, 2018 · 6 comments

Comments

@RaiKave
Copy link

RaiKave commented May 11, 2018

  • SpongeForge version: 1.12.2-2655-7.1.0-BETA-3065

  • Forge version: 14.23.3.2655

  • Java version: 8

  • Plugins/Mods:
    Mod - Car-1.2.11, Mod - Chisel-0.2.0.31, Mod - CLib-1.0.2.31-universal, Mod - CodeChickenLib-3.1.8.341-universal, Mod - CoFHCore-4.4.1.12-universal, Mod - CTM-MC1.12-0.2.3.12, Mod - Currency-1.3.2, Mod - CustomNPCs_(20jan18), Mod - ExtremeReactors-0.4.5.48, Mod - Fexcraft Common Library-XII.40, Mod - FSMM-2.1.0f, Mod - GalacticraftCore-4.0.1.176, Mod - Galacticraft-Planets-4.0.1.176, Mod - LycanitesMobsComplete+1.20.1.0+, Mod - MatterOverdrive-0.6.0.157-universal, Mod - MCrayfish-4.2.0, Mod - Mekanism-9.4.10.345, Mod - MekanismGenerators-9.4.10.345, Mod - MekanismGenerators-9.4.10.345, Mod - Pam's HarvestCraft, Mod - Pam's HarvestCraft, Mod - Pam's HarvestCraft, Mod - Techguns-2.0.1.1, Mod - ThermalDynamics-2.4.1.10-universal, Mod - ThermalDynamics-2.4.1.10-universal, Mod - ThermalFoundation-2.4.1.15-universal, Mod - Worldedit-6.1.8, Mod - Zerocore-0.1.2.1

When we was playing, we realise than the console was spammed from error and causing timed out, that became unplayable un all is due to sponge because without sponge there is no errors.

https://gist.github.com/phit/d7962d2f4a8ca9f8d4abc7c998ecd935

@phit phit added the version: 1.12 API 7 label May 11, 2018
@gabizou
Copy link
Member

gabizou commented May 11, 2018

Closing as it's not a Sponge issue but an issue with Techguns2 issue where they're checking instances and then casting anyways.

Even in IDE this will be flagged as a warning:
screen shot 2018-05-11 at 1 25 27 pm

If I have time I'll submit a PR to Techguns2 since the mod appears to be updated on github.

@RaiKave
Copy link
Author

RaiKave commented May 11, 2018 via email

@gabizou
Copy link
Member

gabizou commented May 11, 2018

pWn3d1337/Techguns2#38. For reference.

@RaiKave
Copy link
Author

RaiKave commented May 11, 2018 via email

@RaiKave
Copy link
Author

RaiKave commented May 11, 2018 via email

@gabizou
Copy link
Member

gabizou commented May 11, 2018

That's more of a networking exception. You'd need to open a new issue with a full log to get some help on that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants