This repository has been archived by the owner on Feb 27, 2024. It is now read-only.
Avoid crashing on invalid Plugin annotations #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephan-gh
suggested changes
Jan 21, 2019
| @@ -55,12 +56,21 @@ public void visit(String name, Object value) { | |||
| checkNotNull(name, "name"); | |||
| switch (name) { | |||
| case "id": | |||
| if (!(value instanceof String)) { | |||
| throw new InvalidPluginException("Plugin annotation has invalid element 'id'"); | |||
There was a problem hiding this comment.
Plugin annotation -> Dependency annotation for all exceptions in this file.
| checkState(State.DEFAULT); | ||
| checkNotNull(name, "name"); | ||
| if (name == null) { | ||
| throw new InvalidPluginException("Plugin annotation has null element"); |
There was a problem hiding this comment.
Can you clarify that name is null, e.g. Plugin annotation attribute name is null
stephan-gh
approved these changes
Jan 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An
InvalidPluginExceptionis thrown, the plugin is skipped and the exception printed.I think I've covered every possible case.
Fix #373