Android P development 2 #27
Comments
|
@Spookcity , you're last release works quite correctly , but i encounter a problem with MMS and emoji in SMS have you the same ? |
|
The last LineageOS 16 is fluid and works pretty well. Calling, sms, data etc. works. I also spotted some weird symbols in the log: From dmesg is this one: Thanks again for doing this stuff! Android 9 on a device that's 5 years old and was only supported till Android 6 is great! |
|
@polaurent Interesting,I honestly don't use SMS or MMS at all really,so I'm not sure. What exactly is the issue? @Mikahlo Thanks a lot for the log and info. Strangely enough I do not have the issue of WiFi disconnecting. I will look into my commits and see if perhaps I did something that may have caused this. I'm not too sure what the KernelWakelockReader error is about either. It seems weird indeed. I will look into it. Side note: I have made some progress with our storage issues I believe. Downloading album cover art etc via certain music apps now works as well as an issue I had with copying items from extSD or lan/samba folder to internal storage in MiXplorer. Hopefully other issues will be solved as well. I want to look over my commit later,but will push to my kernel repo soon after. |
|
@Spookcity : MMS are unable to be downloaded ( photos ) , in received SMS all emoji are "?" . |
|
@polaurent Yes,that is def a problem. Is this something that had worked for you in previous builds or had you not tried? I looked over my commits and saw none that should have had any effect on this. Also,This commit has fixed a number of storage problems for me. So simple,yet so easily overlooked. I am going to upload the new boot image (for LOS 16 only) if anyone would like to try and perhaps give some feedback.Thanks! Just make sure to select "install image" in TWRP and be SURE to select boot partition!! |
|
@Spookcity :Concerning your Bootimage, it as not make any change but by the way it's my fault, i forget to check the restore default APN, the previous auto-created was buggy ( but looks correct, greyed and not editable), not sure that it's not a post boot error. Another thing, as i get an SD card installed as Internal storage, each time after reboot and before unlocking the phone, i got a message concerning the SD card telling it's not installed ( seems to be a feature cause the card is scrambled but curious). |
|
@Spookcity : i think it as something to be in reference of the multi-user schema and an existing "guest" profile. last report, i loose sometimes the data connection activity ( think following roaming ), i've to reactivate it manually. |
|
@Spookcity : tested the boot image, copied stuff with MiX, internal and external sd, FTP'd stuff around, made backups, edited files and saved my game in Andor's Trail xD |
|
@polaurent I'm not fully sure I understand what is going on. Any chance you can provide a log? @Mikahlo Great! Many thanks for testing and providing feedback. I will try to do some looking into the WiFi issue as well as the strange KernelWakelockReader error soon. |
|
@Spookcity : no worries, I take logs frequently to figure out if the wifi issue is a problem with android or my router. The disconnect happens quiet often so I should be able to make a better guess on what's going on. I really do not know anything about the wakelock stuff. It could be connected with the higher battery drain especially when the modem is used. My experience so far is that the battery life is the same as the android 7 builds when the phone is in flight mode. As soon as the flight mode is turned off, the battery drain is huge. |
|
Yeah,it is certainly possible that the wakelock error is causing some unnecessary battery drain. Strangely,my battery life is pretty great on Pie builds. EIther way, I stumbled upon This by accident really and it appears that this is all that was needed to fix our WiFi hotspot. So I am going to disable some things in our kernels default config that were enable trying to sort this out. We shall see if it changes anything. |
|
Hello.) The creators of LineageOS updated to Android Pie devices five years ago .. Perhaps there are ideas for correcting errors on s 5mini? |
|
Hey @Oleggluk Good to see you around stranger! Thanks for the link I will check it out. I will say though,that LOS 16 is already very stable imo. Much more so than any Oreo was. The only real issues that I am aware of is NFC and HW composition. NFC may never be fixed and the HW composition is seeming more and more like our libdisplay.so or hwcomposer.exynos3.so needs to be hex edited to fix. |
wifi issuesThese lines are from the latest logcat I took. Maybe one of them leads to a hint of what is going on. 03-26 06:41:56.306 E/android.hardware.wifi@1.0-service( 2151): Failed to register radio mode change callback 03-26 19:01:41.527 E/WifiScanner( 2337): listener cannot be found |
|
@Mikahlo Thanks a lot for the log. Such a weird issue. You are not alone as another user reported WiFi disconnects on XDA. It's strange because my WiFi is very stable. I will try to track this down. I think I may move the android.hardware.wifi HIDL back to version 1.0. I think the newer versions have addition features that our device doesn't support anyway. Perhaps with some luck this will solve it. |
|
wifi insanity Quick update: nothing. The issue could be anything. Drivers, kernel, network services or applications, ipv4 or ipv6. I have some parts of a log and dmesg which show symptoms but no reasons. 04-14 10:17:43.073 I/wpa_supplicant( 2952): wlan0: WPA: Group rekeying completed with ::::73:84 [GTK=CCMP] [20518.277154] [0] 5785 CFG80211-INFO2) wl_cfg80211_disconnect : Reason 3 [20525.613099] [3] 2111 Dongle Host Driver, version 1.141.64.27 (security_patch) Maybe the issues will get solved with future repo updates on the lineage side. |
|
@Spookcity another small update: since yesterday I'm using your AEX ROM from mid april and the wifi issue seems to be gone. No disconnections till now. I also updated TWRP to 3.3.0-0. |
|
@Mikahlo Very interesting. That's good to know. If that's the case then it's obviously something within the Lineage sources. Please let me know if you have any disconnects while using AEX,because if not I'll try to look into what the differences might be within the 2 sources. I made 25-ish commits to the kernel related to wireless,but if it's something in the sources then it won't matter. |
|
@Spookcity After testing some more the issue reoccurred. The difference is that wifi sometimes reconnects itself in standby and this connection is than stable. It's really a weird issue. You should be enable to reproduce this by connecting to a network, put the phone in standby and look after around 3 to 5 minutes. It should than be disconnected. The baseband/modem doesn't seem to influence this. |
|
@Mikahlo Thanks a lot for the update. A bit of a shame as it may have been easier to figure out if it was purely related to LOS sources. I have tried to reproduce this over the last day or two (paying closer attention when I wake my phone) I am not able to. My WiFi never seems to disconnect. I can't think of any reason why I don't have this issue and you do. I use a static IP for my phone though. Although this is rather recent (last month or so) and I highly doubt this has anything to do with it. My WiFi was stable before this as well. I will continue to try to investigate when time permits. |
|
Hello (committed a long time ago...) |
|
Hey @skulko Seems like you are correct. I am honestly not really sure what effect this has,but I will change this to false and commit later. Thanks! Any and all help is greatly appreciated! |
|
@Spookcity Great thanks! though I agree, it probably won't change much.. |
|
@skulko Nope, no need to apply binary_patcher.sh as it's already applied. |
|
Hi, But since the s5 mini also supports 802.11 N shouldn't it be |
|
@skulko I actually added the WiFI band for Pie builds. It was never there in the past. If I remember I will add "N" and do a build and see what happens,but in all honesty I am nearly positive this has no effect on anything. |
|
Hey Spook thanks for your reply. I only had to add a small piece of the puzzle... what I experienced so far is there is a little catch with NFC fix, it will only work if it is turned on during boot phase. Therefore if you power off with nfc turned off it won't work the next time. |
|
@skulko Ahh yes, this was a similar issue that I had if I recall correctly. I really dont know to be honest. I saw This commit and this is when I gave up as it is my understanding that it is just broken and beyond my knowledge to fix at this point. Wish I could be more helpful,sorry,but unless someone has worked on this I am afraid it is beyond my skill level. |
|
I looked over it and I think the problem with this commit is our outdated extract-files.sh: on line 29 it would only look proprietary-files.txt but we would most likely need to add another (proprietary-files-pn547.txt). we could maybe try adding nci.msm8974.so directly to proprietary-files.txt and make changes accordingly.. but this leaves me with where to get this file...does s5mini share the same nfc fw with s5 (libpn547_fw)? |
|
@skulko Yeah, idk. I only know this because I spent a good deal of time trying to get this to work, so I did a lot of searching. Gave myself a headache over it 😀 I think I may have stumbled upon that patch you posted as well. Not positive, but I tried anything I could possibly think of (or found) to get this working with no luck at all. |
|
I believe you, I hope I am not straining your nerves with these (old) issues again... Maybe the last thing I can come up with right now is that the file in libnfc-sec-hal.conf (last line): RFREG_FILE="/etc/sec_s3fwrn5_rfreg.bin" is missing on the device. I think we could get it from here |
|
uh the file is not missing but rather the location in libnfc-sec-hal.conf should be RFREG_FILE="/system/vendor/etc/sec_s3fwrn5_rfreg.bin" |
|
@skulko No, not straining my nerves at all. Enough time has passed for me to be able to revisit this without annoyance 😀 I just wish I could be of more helpful, but I really have no new ideas on this. Perhaps you're onto something with the location? This is something I'm pretty sure I never noticed. |
|
about the camera: I set TARGET_USES_GRALLOC1 := true in BoardConfigCommon.mk, and reverted the patch for switching graphics allocator to passthrough. It 's a bit more stable, I guess but still no video rec'... I can do a pull request if you like... |
|
Yeah, sounds good to me. I saw the NFC pull require also. I'll take care of that when I'm at my PC. The NFC issue is just a pain. I'm glad I'm not the only one who found this out haha |
|
hehe yes no problem.I know the feeling now 🗡️ :) Also for the camera i tried setting (both): |
|
Hehe,yes. Seems like maybe I tried one or both of these flags at some point, but it's been so long I really don't recall. Maybe I didn't. Either way, it's been enough time that perhaps things have changed within the ROM sources to yield better results. It could be a patcher issue indeed. I'd have to have a look. |
|
I could probably do without virtualbox, now that no special java/jre is required. Sometimes it works but on other occasions its just a black screen when I boot up virtualbox. Anyway, I believe this might fix the video recording issue. It looks like it wasn't ported to P/Lineage-16. |
|
I can't honestly say whether I tried this or not. Maybe it will fix it. That would be great! I created a patch. Hopefully it will apply OK. If not I will work on it tomorrow if I have more time. I will also try a build with it when time permits. I'll just go ahead push the patch and if it doesn't work or apply properly I'll fix or remove later. Thanks again for working on this! |
|
darn,no luck. The patch didn't work in the first place so i changed What I didn't try but might be wort it is: |
|
Hmm,well that's a shame. Guess we just can't be that lucky. Sorta like the NFC issue,I tried many things,but it's been so long I kinda forget exactly what I did. Just lots of searching on here and gerrit for similar devices to see if it was resolved. Obviously without luck. If time permits I will try to do a bit more searching into this. |
|
I wonder what the purpose of hardware/samsung_slsi/exynos3470/Android.mk is, since the if clauses seem to prevent that the content/variables there are used. regards |
|
I'll be honest, I'm not really sure off hand. I'd have to have a closer look. Very interestingly, I once did a build with the whole samsung_slsi...directory excluded by accident. I don't remember noticing any issues. I found that very strange, but forgot about it and never looked into it. I suppose there had to be some audio issues at the very least without it, but I don't remember. |
|
Hmm this is odd but interesting indeed. Because what I see is that in smdk3470-common/BoardConfigCommon.mk TARGET_PRODUCT_PLATFORM is 'exynos3' but Android.mk in hardware/samsung_slsi/exynos3470 requires exynos5: |
|
Interesting indeed. I think you are probably onto something there. This would also explain why I noticed no ill effects, at least in a short time testing, with this directory excluded. I should have investigated this further when this happened, but got distracted I guess. |
|
I patched the file with what I was able to link to the new source, but no improvement. Maybe some less errors/warning relating to codecs, but not sure. Maybe we could need an additional shim for graphicsbuffer like here , because this looks really bad in log when trying to record: |
|
Interesting. Hopefully I'll be able to find some time this weekend and I'll connect to adb and try and record a video and see what it spits out. It's been a long time since I've done this. I know how to create shims for missing symbols, but would have to do some researching on creating other types of shims. |
|
Trust me,you are not alone in that. I just constantly search Google/Github/Gerrit :) I will try to look into this stuff over the weekend as long as I have the time. Time is just something I've really been lacking lately sadly. |
|
You're probably right... :-/ I guess there is too much different hardware and abbreviations around. I wonder, how any single person can keep track.. For the camera, it might all boil down to this:
No idea if it would work after reverting so much code... |
|
...oh support for metadata in video buffer was restored I think. So no problem there.
|
|
Ahh,nice. I was hoping to spend some time on this over the weekend, as well as build an update for LOS 16 since the April security patch is now merged, but once again time was not on my side. Hopefully this week. I will try a build with this and see how it works. Thanks again for looking into all of this. I appreciate it and really hope I'm able to find the time soon to help out some. |
|
The problem is most likely related with video buffer or something similiar in hardware. |
|
Yep,I think you are probably right about that. I'm not really sure how to go about implementing something similar for our device. I'd have to do some research on that. |
|
I recently looked over your OC commits in kernel and in line 147 in /drivers/gpu/arm/mali400/mali/platform/exynos3470/exynos4_pmm.c I might have found a mistake: |
|
@skulko Hah,interesting. I haven't messed with this in forever,but I am sure you're correct and that's a typo on my part. Thanks for pointing it out! |
|
Hello Spook May I ask, how did you find the value for TARGET_ADDITIONAL_GRALLOC_10_USAGE_BITS := 0x4000000 (commit bea98ef37c67eeaafbb8d57e92c6a9933787aeaa)? I'm asking because I might have found a solution for this frequent error Best, |
|
Hey @skulko , It has been awhile,but I got the specific value simply by connecting to adb shell and looking at the error/warning while running logcat |
A continuation of #26
The text was updated successfully, but these errors were encountered: