This repository has been archived by the owner on Nov 25, 2020. It is now read-only.
feat(component): add form-errors custom element #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bas080
force-pushed
the
fix/validation
branch
from
6315599
to
0f147d3
Compare
RWOverdijk
suggested changes
Feb 6, 2017
src/component/form-errors.html
Outdated
| <template> | ||
| <p class="help-block" repeat.for="message of messages">${message}</p> | ||
| </template> | ||
|
|
| <template> | ||
| <p repeat.for="message of messages">${message}</p> | ||
| </template> | ||
|
|
src/config.js
Outdated
| // ValidationResult instance | ||
| errorMessage: error => error.message, | ||
| errorValid : error => error.valid | ||
|
|
| constructor(config) { | ||
| this.config = config.configurations; |
There was a problem hiding this comment.
Align consecutive assignments
| <association-select | ||
| attributes.bind = "formField.element.attributes" | ||
| multiple.bind = "formField.element.multiple" | ||
| value.bind = "formField.value" | ||
| property.bind = "formField.element.property" | ||
| repository.bind = "formField.element.repository" | ||
| resource.bind = "formField.element.resource" | ||
|
|
||
| type.bind = "formField.element.selectType" |
There was a problem hiding this comment.
This allows for checkboxes or select type to be chose for aurelia-orm's association-select component.
There was a problem hiding this comment.
It might be best to make this part of a seperate pull request
src/component/form-fields.js
Outdated
| @@ -10,7 +10,7 @@ export class FormFields { | |||
| @bindable({defaultBindingMode: bindingMode.twoWay}) | |||
| model | |||
|
|
|||
| @bindable messages | |||
| @bindable errors | |||
There was a problem hiding this comment.
Semicolon (apply everywhere);
src/component/form-errors.js
Outdated
| } | ||
|
|
||
| } | ||
|
|
src/component/form-errors.js
Outdated
| export class FormErrors { | ||
|
|
||
| @bindable | ||
| errors; |
There was a problem hiding this comment.
Put on same line as @bindable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a globalized form-errors component. Also adds the association-select's type bindable.